Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs for conv2d #1465

Merged
merged 9 commits into from
Jul 26, 2018
Merged

Fixed bugs for conv2d #1465

merged 9 commits into from
Jul 26, 2018

Conversation

Laurawly
Copy link
Contributor

Solved bugs raised by @zhreshold and #1420

@Laurawly Laurawly changed the title Fixed bugs for conv2d [WIP] Fixed bugs for conv2d Jul 20, 2018
@Laurawly Laurawly changed the title [WIP] Fixed bugs for conv2d Fixed bugs for conv2d Jul 20, 2018
@tqchen
Copy link
Member

tqchen commented Jul 21, 2018

please follow https://docs.tvm.ai/contribute/code_review.html#ensure-test-coverage to add regression testcase to avoid this from happening again

@tqchen tqchen added status: review in progress status: need update need update based on feedbacks labels Jul 21, 2018
@zhreshold
Copy link
Member

Thanks @Laurawly for fixing it. I can confirm it works for my workloads.

However apparently the default kernels are not optimized for intel graphic cards, therefore it's running much slower than cpu with apple blas. I will look into autotvm later.

@Laurawly
Copy link
Contributor Author

Mac intel graphics doesn’t recognize intel sub group shuffling instructions somehow, that’s why you have to call the cuda schedule which is not optimized for intel graphics. @tqchen should we make the intel subgroup shuffle instructions banned when running on intel graphics on Mac?

@zhreshold
Copy link
Member

Just had a quick conversation with Yida offline, he mentioned there's Intel's extension to OpenCL which adds support of subgrouping, just wondering if you are familiar with that on Mac?

@tqchen tqchen merged commit d49034e into apache:master Jul 26, 2018
tqchen pushed a commit to tqchen/tvm that referenced this pull request Aug 4, 2018
sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants