-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bugs for conv2d #1465
Fixed bugs for conv2d #1465
Conversation
please follow https://docs.tvm.ai/contribute/code_review.html#ensure-test-coverage to add regression testcase to avoid this from happening again |
Thanks @Laurawly for fixing it. I can confirm it works for my workloads. However apparently the default kernels are not optimized for intel graphic cards, therefore it's running much slower than cpu with apple blas. I will look into autotvm later. |
Mac intel graphics doesn’t recognize intel sub group shuffling instructions somehow, that’s why you have to call the cuda schedule which is not optimized for intel graphics. @tqchen should we make the intel subgroup shuffle instructions banned when running on intel graphics on Mac? |
Just had a quick conversation with Yida offline, he mentioned there's Intel's extension to OpenCL which adds support of subgrouping, just wondering if you are familiar with that on Mac? |
This reverts commit ed7fabc.
Solved bugs raised by @zhreshold and #1420