Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU][ETHOSU] Add option to disable copying constants for case without cascader #15147

Merged

Conversation

Aleksei-grovety
Copy link
Contributor

@Aleksei-grovety Aleksei-grovety commented Jun 23, 2023

Added the option to disable copying constants for the case when the user determines in the linker script for section ".rodata.tvm" that the constants are located in SRAM.
To activate this option, pass the --target-ethos-u-disable_copying_constants=1 argument to tvmc.

cc @neildhickey, @lhutton1, @ekalda, @leandron

…ithout cascader

Added the option to disable copying constants for the case when the user determines in the linker script for section ".rodata.tvm" that the constants are located in SRAM.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 23, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a small comment, otherwise LGTM!

src/relay/backend/contrib/ethosu/compiler_attrs.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aleksei-grovety, LGTM!

@lhutton1 lhutton1 merged commit 5e77b7e into apache:main Jun 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants