Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU][ETHOSU] Fix compiler attributes types #15159

Merged

Conversation

Aleksei-grovety
Copy link
Contributor

The bool type is replaced with tvm::Bool to pass these parameters to tvmc via the command line.

cc @neildhickey, @lhutton1, @ekalda, @leandron

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 26, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Aleksei-grovety, is it possible to add some tests?

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aleksei-grovety, LGTM! It looks like this got conflicted with #15147, so it'll need a quick rebase first :)

tests/python/driver/tvmc/test_target_options.py Outdated Show resolved Hide resolved
The bool type is replaced with tvm::Bool to pass these parameters to tvmc via the command line.
@Aleksei-grovety Aleksei-grovety force-pushed the ethosu-fix-compiler-attributes-types branch from fba84f9 to 70f60ef Compare June 28, 2023 09:19
@Aleksei-grovety Aleksei-grovety force-pushed the ethosu-fix-compiler-attributes-types branch from 70f60ef to 72302df Compare June 28, 2023 09:25
@lhutton1 lhutton1 merged commit 6cf5b09 into apache:main Jun 29, 2023
18 checks passed
@lhutton1
Copy link
Contributor

Thanks @Aleksei-grovety!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants