[Fix] Broken Windows Build with LLVM #16081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR apache#16032 introduces a more stable way of zstd path finding by relying on LLVM's existing Findzstd module, but it turns out that the cmake dir from `llvm-config` is not very compatible with CMake's internal convention, and thus a conversion is required to get rid of the error message below: ``` -- Performing Test CMAKE_HAVE_LIBC_PTHREAD D:/a/package/package/tvm/build/CMakeFiles/CMakeScratch/TryCompile-tnlfb1/CMakeLists.txt:2 -- Configuring incomplete, errors occurred! when parsing string C:\Miniconda\envs\tlcpack-build\Library\lib\cmake\llvm Invalid character escape '\M'. ```
tqchen
approved these changes
Nov 7, 2023
|
Thanks for checking the windows build @junrushao! |
binarybana
pushed a commit
to binarybana/tvm
that referenced
this pull request
Nov 14, 2023
PR apache#16032 introduces a more stable way of zstd path finding by relying on LLVM's existing Findzstd module, but it turns out that the cmake dir from `llvm-config` is not very compatible with CMake's internal convention, and thus a conversion is required to get rid of the error message below: ``` -- Performing Test CMAKE_HAVE_LIBC_PTHREAD D:/a/package/package/tvm/build/CMakeFiles/CMakeScratch/TryCompile-tnlfb1/CMakeLists.txt:2 -- Configuring incomplete, errors occurred! when parsing string C:\Miniconda\envs\tlcpack-build\Library\lib\cmake\llvm Invalid character escape '\M'. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16032 introduces a more stable way of zstd path finding by relying on LLVM's existing Findzstd module, but it turns out that the cmake dir from
llvm-configis not very compatible with CMake's internal convention, and thus a conversion is required to get rid of the error message below:CC @lhutton1