Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] zstd.dll installation on Windows #1135

Closed
David-Sharma opened this issue Oct 26, 2023 · 5 comments
Closed

[Doc] zstd.dll installation on Windows #1135

David-Sharma opened this issue Oct 26, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@David-Sharma
Copy link
Contributor

📚 Documentation

Suggestion

Please review and update the following from this page:
https://llm.mlc.ai/docs/install/tvm.html#install-tvm-unity

original: It is likely zstd, a dependency to LLVM, was missing. Please download the precompiled binary, rename it to zstd.dll and copy to the same folder as tvm.dll

Suggested:
It is likely zstd, a dependency to LLVM, was missing. Please download the precompiled binary, rename it to zstd.dll and copy to the same folder as tvm.dll. Hint - Perform a search for "tvm.dll" and identify the folder in which the path includes the name of the current environment eg. mlc-chat-venv. Copy zstd.dll to that folder.

Bug

  • Link to the buggy documentation/tutorial:
  • Description of the bug:
    This suggestion is based on the following reported by @Sing-Li

Please pardon my (possible) related comment. The Note section above. Downloading and "rename it to zstd.dll and copy to the same folder as tvm.dll" part of the instruction --- is almost impossible for new users to accomplish because they have to understand how conda relates to python, and where miniconda keeps its python site libs before they can find "the same folder as tvm.dll". I hope one of the above fixes will make sure that zstd.dll is always included as part of the tvm bundle/nightly

@junrushao
Copy link
Member

This is a headache I really wanted to resolve :(

@junrushao
Copy link
Member

One easier way I found is to install zstd in conda, which even works nicely with Windows:

conda install zstd

@junrushao
Copy link
Member

I don’t think it’s complete :(( Eventually we should be able to pack zstd with TVM so no extra steps are required

@junrushao junrushao reopened this Nov 5, 2023
@junrushao
Copy link
Member

Happy to share the zstd issue seems resolved with a few latest changes!

Would you guys mind trying out tomorrow with the latest nightly build?

@junrushao
Copy link
Member

Closing as the issue has been addressed. Feel free to create new ones if it persists!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants