Cut pytest-lazy-fixture #16512
Merged
Cut pytest-lazy-fixture #16512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytest-lazy-fixture doesn't work with version pytest==8.0.0 The following error occurs: AttributeError: 'CallSpec2' object has no attribute 'funcargs' This has been raised as an issue on the pytest-lazy-fixture project, but the repository is not in active development. See TvoroG/pytest-lazy-fixture#65 This patch removes the use of the library to resolve the problem. Change-Id: Ic899e6b7dac12dc786f79ac7052f75475e8546c9
neildhickey
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
@Liam-Sturge thanks for this contribution.
We'll have to regenerate the correct docker images and update once this change has gone in.
Perhaps we can put up a draft review pointing to the new docker images once they are built? Just to be doubly sure CI works still
This was referenced Feb 2, 2024
|
Thanks @Liam-Sturge @neildhickey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest-lazy-fixture doesn't work with
pytest==8.0.0The following error occurs when pytest-lazy-fixture is called:
This has been raised as an issue on the pytest-lazy-fixture project, but the repository is not in active development. See TvoroG/pytest-lazy-fixture#65 for details.
TVM project code-base makes very little reference to pytest-lazy-fixture, so this patch removes the library from the project altogether, in order to resolve the problem.
CC @neildhickey @lhutton1 @tqchen