Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB] Move ArtifactCache to Interface, Support Cache delete and Batch Delete, Remove typo #16525

Merged
merged 1 commit into from Feb 19, 2024
Merged

[WEB] Move ArtifactCache to Interface, Support Cache delete and Batch Delete, Remove typo #16525

merged 1 commit into from Feb 19, 2024

Conversation

DiegoCao
Copy link
Contributor

@DiegoCao DiegoCao commented Feb 5, 2024 •
edited

  • Move old artifact cache as a interface template to support future IndexDB cache fetch
  • Add deleteInCache api in cache template
  • Fix one test path error
  • Parallelize Downloading Process

Co-authored-by: DavidGOrtega g.ortega.david@gmail.com for parallel download

@tqchen
Copy link
Member

tqchen commented Feb 6, 2024

please fix the ci errors

@DiegoCao DiegoCao marked this pull request as draft February 6, 2024 21:11
@DiegoCao
Copy link
Contributor Author

DiegoCao commented Feb 6, 2024

Will re-open after supporting batch delete weights

@DiegoCao DiegoCao force-pushed the archi-cache branch 4 times, most recently from 23960bd to 4b55a1b Compare February 12, 2024 01:52
@DiegoCao DiegoCao changed the title [WEB] [MINOR] Move ArtifactCache to Interface to support future different cache typ… [WEB] Move ArtifactCache to Interface, Support Cache delete and Batch Delete, Remove typo Feb 12, 2024
@DiegoCao DiegoCao marked this pull request as ready for review February 12, 2024 04:08
@CharlieFRuan
Copy link
Contributor

Will take a look tomorrow; thank you @DiegoCao!

CharlieFRuan
CharlieFRuan reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@CharlieFRuan CharlieFRuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new interface and deleteInCache() looks good to me! Thanks for the changes.

I left some comments on deleteNDArrayCache(), let me know what you think!

web/src/runtime.ts Outdated Show resolved Hide resolved
web/src/runtime.ts Outdated Show resolved Hide resolved
web/src/runtime.ts Outdated Show resolved Hide resolved
web/src/runtime.ts Outdated Show resolved Hide resolved
web/src/runtime.ts Outdated Show resolved Hide resolved
@DiegoCao DiegoCao force-pushed the archi-cache branch 3 times, most recently from 7d61b4a to 4c99370 Compare February 18, 2024 14:03
CharlieFRuan
CharlieFRuan reviewed Feb 18, 2024
View reviewed changes
Copy link
Contributor

@CharlieFRuan CharlieFRuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good, thank you!

web/tvm_home Outdated Show resolved Hide resolved
web/src/runtime.ts Outdated Show resolved Hide resolved
web/src/runtime.ts Outdated Show resolved Hide resolved
@DiegoCao @DavidGOrtega
Parallel Download, Move ArtifactCache to Interface to support future …
70911c5 
…different cache types, fix README path typo, Support delete and batch delete

Co-authored-by: DavidGOrtega <g.ortega.david@gmail.com>
@DiegoCao
Copy link
Contributor Author

DiegoCao commented Feb 18, 2024 •
edited

All issues are resolved, will later pr the corresponding webLLM side API

@CharlieFRuan
Copy link
Contributor

Thank you! I think this is ready to be merged cc @tqchen

@tqchen tqchen merged commit 40ec469 into apache:main Feb 19, 2024
18 checks passed
@CharlieFRuan CharlieFRuan mentioned this pull request Feb 20, 2024
Open
5 tasks
@DavidGOrtega DavidGOrtega mentioned this pull request Feb 27, 2024
Closed
@ysh329 ysh329 mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieFRuan CharlieFRuan CharlieFRuan left review comments

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DiegoCao @tqchen @CharlieFRuan