Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message in NDArray::CopyFromTo #16539

Merged
merged 1 commit into from Feb 13, 2024
Merged

Improve error message in NDArray::CopyFromTo #16539

merged 1 commit into from Feb 13, 2024

Conversation

ekalda
Copy link
Contributor

@ekalda ekalda commented Feb 7, 2024

Make it explicit that the quoted numbers are bytes.

@ekalda
Improve error message in NDArray::CopyFromTo
cac467b 
Make it explicit that the quoted numbers are bytes.
@ekalda
Copy link
Contributor Author

ekalda commented Feb 7, 2024

cc @lhutton1 @eirenevp

quic-sanirudh
quic-sanirudh approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

lhutton1
lhutton1 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a rebase to pass CI

@ekalda
Copy link
Contributor Author

ekalda commented Feb 12, 2024

@tvm-bot rerun

@lhutton1 lhutton1 merged commit bb2adbf into apache:main Feb 13, 2024
20 checks passed
@lhutton1
Copy link
Contributor

Thanks @ekalda @quic-sanirudh!

@ekalda ekalda deleted the ndarray-error-message branch February 13, 2024 09:14
@ysh329 ysh329 mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhutton1 lhutton1 lhutton1 approved these changes

@quic-sanirudh quic-sanirudh quic-sanirudh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekalda @lhutton1 @quic-sanirudh