[Runtime] Add "TVM_DLL" to NDArray cache load func #16541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tvm-bot rerun |
1 similar comment
|
@tvm-bot rerun |
The `NDArrayCacheMetadata::Load` function lacks the `TVM_DLL` attribute which leads to build failure on Windows. This PR fixes the issue.
MasterJH5574
force-pushed
the
tvm-dev/2024-02-07-windows-dll
branch
from
a909626
to
50382cc
Compare
tqchen
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NDArrayCacheMetadata::Loadfunction lacks theTVM_DLLattribute which leads to build failure on Windows. This PR fixes the issue.