[AOT][Testing] Print output values on test failure #16611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the AOT test harness to print the "actual" and "reference" values when there is a mismatch. This helps when debugging a failing test. Sample output: ``` Actual, Reference 8.502946, 8.887751 9.810405, 9.108611 8.563767, 9.041000 10.019511, 9.190888 .... ``` Change-Id: Ifff729744c74b6a5256b4fd47c8580be3f5c32a9
|
Thanks @lhutton1, would you mind adding a test for this change? There is currently no path that exercises this option. |
lhutton1
force-pushed
the
aot-show-values
branch
from
1cc9822
to
1d9d600
Compare
ekalda
reviewed
Feb 22, 2024
| @@ -93,6 +93,7 @@ def test_conv_with_params(interface_api, use_unpacked_api, test_runner): | |||
| test_runner, | |||
| interface_api, | |||
| use_unpacked_api, | |||
| print_output_on_mismatch=True, | |||
There was a problem hiding this comment.
What is the reason for setting that option for this specific test?
There was a problem hiding this comment.
I added this just to exercise the case when the option is used, but there is no output mismatch
ekalda
approved these changes
Feb 26, 2024
Lunderberg
pushed a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 12, 2024
This commit enhances the AOT test harness to print the "actual" and "reference" values when there is a mismatch. This helps when debugging a failing test. Sample output: ``` Actual, Reference 8.502946, 8.887751 9.810405, 9.108611 8.563767, 9.041000 10.019511, 9.190888 .... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the AOT test harness to print the "actual" and "reference" values when there is a mismatch. This helps when debugging a failing test. Sample output: