Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Fix NDArrayCache loading report callback #16631

Merged
merged 1 commit into from Feb 23, 2024
Merged

Conversation

rickzx
Copy link
Contributor

@rickzx rickzx commented Feb 23, 2024

This PR fixes an issue where the NDArrayCache loading report callback is inaccurate after parallel download support.

@rickzx
Copy link
Contributor Author

rickzx commented Feb 23, 2024

cc: @CharlieFRuan @MasterJH5574

Copy link
Contributor

@CharlieFRuan CharlieFRuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!!

@tqchen tqchen merged commit a6ab8cb into apache:main Feb 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants