[Relax] Implement relax.transform.TopologicalSort #16697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
relax_topological_sort
branch
2 times, most recently
from
dc6e233
to
d976e9d
Compare
This commit implements a utility `relax.transform.TopologicalSort`, which can re-order the bindings that occur in a `relax.DataflowBlock`. This is not intended for use in a general-purpose optimization pipeline, but instead as a utility that may be used as needed in specific cases. For example, normalization of unit tests that should not depend on the order of variable binding.
Lunderberg
force-pushed
the
relax_topological_sort
branch
from
d976e9d
to
2180f87
Compare
masahi
approved these changes
Mar 15, 2024
| @@ -233,6 +233,29 @@ def ToNonDataflow() -> tvm.ir.transform.Pass: | |||
| return _ffi_api.ToNonDataflow() # type: ignore | |||
|
|
|||
|
|
|||
| def TopologicalSort(order="depth-first", direction="from-inputs") -> tvm.ir.transform.Pass: | |||
| """Sort relax.Dataflow blocks | |||
There was a problem hiding this comment.
To be more precise, "Sort bindings in relax.Dataflow blocks with the specified order"?
There was a problem hiding this comment.
Good call, and updated.
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
* [Relax] Implement relax.transform.TopologicalSort This commit implements a utility `relax.transform.TopologicalSort`, which can re-order the bindings that occur in a `relax.DataflowBlock`. This is not intended for use in a general-purpose optimization pipeline, but instead as a utility that may be used as needed in specific cases. For example, normalization of unit tests that should not depend on the order of variable binding. * Update docstring according to review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a utility
relax.transform.TopologicalSort, which can re-order the bindings that occur in arelax.DataflowBlock. This is not intended for use in a general-purpose optimization pipeline, but instead as a utility that may be used as needed in specific cases. For example, normalization of unit tests that should not depend on the order of variable binding.