[VTA] Infinite recursive device_api.ext_dev call fix. #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tmoreau89 , could you help to review this patch? Thanks |
|
error seems unrelated, can you retrigger the CI? |
sure, already done. |
|
@tmoreau89 , just did a force push to trigger CI, but still not get pass, I saw couple PR(3846, 3844,3842) failed in same "git.. corrupted" issue, is this a environment problem? |
Issue when try vta on fpga board, would see a Infinite recursive device_api.ext_dev issue that cause stack overflow and vta failed. Analysis: device_api.ext_dev function in rpc_server.py is use to load vta library, once vta library get load, device_api.ext_dev would get replaced with vta function by vta library, vta device_api.cc did such work, but because a logic issue in VTA.cmake, the said file not get compiled, then vta would keep failing on rpc_server.py. Solution: fix the logic issue in VTA.cmake.
|
The CI has been hanging for quite a while, perhaps retrigger it once more? |
|
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
Issue when try vta on fpga board, would see a Infinite recursive device_api.ext_dev issue that cause stack overflow and vta failed. Analysis: device_api.ext_dev function in rpc_server.py is use to load vta library, once vta library get load, device_api.ext_dev would get replaced with vta function by vta library, vta device_api.cc did such work, but because a logic issue in VTA.cmake, the said file not get compiled, then vta would keep failing on rpc_server.py. Solution: fix the logic issue in VTA.cmake.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
Issue when try vta on fpga board, would see a Infinite recursive device_api.ext_dev issue that cause stack overflow and vta failed. Analysis: device_api.ext_dev function in rpc_server.py is use to load vta library, once vta library get load, device_api.ext_dev would get replaced with vta function by vta library, vta device_api.cc did such work, but because a logic issue in VTA.cmake, the said file not get compiled, then vta would keep failing on rpc_server.py. Solution: fix the logic issue in VTA.cmake.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
Issue when try vta on fpga board, would see a Infinite recursive device_api.ext_dev issue that cause stack overflow and vta failed. Analysis: device_api.ext_dev function in rpc_server.py is use to load vta library, once vta library get load, device_api.ext_dev would get replaced with vta function by vta library, vta device_api.cc did such work, but because a logic issue in VTA.cmake, the said file not get compiled, then vta would keep failing on rpc_server.py. Solution: fix the logic issue in VTA.cmake.
JackYoustra
added a commit
to JackYoustra/tvm
that referenced
this pull request
May 6, 2021
apache#3843 fixed the infinite recursive call for the Xilinx boards, but didn't fix it for the intel boards. This fixes it for the DE10 (same missing symbol problem with same fix).
tqchen
pushed a commit
that referenced
this pull request
May 6, 2021
#3843 fixed the infinite recursive call for the Xilinx boards, but didn't fix it for the intel boards. This fixes it for the DE10 (same missing symbol problem with same fix).
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
apache#3843 fixed the infinite recursive call for the Xilinx boards, but didn't fix it for the intel boards. This fixes it for the DE10 (same missing symbol problem with same fix).
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
apache#3843 fixed the infinite recursive call for the Xilinx boards, but didn't fix it for the intel boards. This fixes it for the DE10 (same missing symbol problem with same fix).
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
apache#3843 fixed the infinite recursive call for the Xilinx boards, but didn't fix it for the intel boards. This fixes it for the DE10 (same missing symbol problem with same fix).
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
apache#3843 fixed the infinite recursive call for the Xilinx boards, but didn't fix it for the intel boards. This fixes it for the DE10 (same missing symbol problem with same fix).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
when try vta on fpga board, would see a Infinite recursive
device_api.ext_dev issue that cause stack overflow and vta
failed.
Analysis:
device_api.ext_dev function in rpc_server.py is use to load
vta library, once vta library get load, device_api.ext_dev would
get replaced with vta function by vta library, vta device_api.cc
did such work, but because a logic issue in VTA.MAKE, the said file
not get compiled, then vta would keep failing on rpc_server.py.
Solution:
fix the logic issue in VTA.MAKE.