[PASS]LoopPartition #56

ZihengJiang · 2017-02-27T03:23:46Z

No description provided.

…der multiple partitions

ZihengJiang · 2017-03-01T21:14:22Z

tests/python/unittest/test_pass_loop_partition.py

+bounds = tvm.schedule.InferBound(s)
+stmt = tvm.schedule.ScheduleOps(s, bounds)
+stmt = tvm.ir_pass.LoopPartition(stmt)
+print(stmt)


any suggestion to add assert statement and construction strong test case?

we can assert the result AST
something like

str(stmt.condition) == xyz

Let us also add end to end test cases, to test elementwise add and gemm, to make sure the result program looks correct

tqchen · 2017-03-01T21:54:35Z

include/tvm/ir_pass.h

@@ -137,6 +137,8 @@ Stmt InjectVirtualThread(Stmt stmt);
 */
 Stmt LiftAllocate(Stmt stmt);

+Stmt LoopPartition(Stmt stmt);


always document functions in header

tqchen · 2017-03-01T21:56:56Z

tests/python/unittest/test_pass_loop_partition.py

+bounds = tvm.schedule.InferBound(s)
+stmt = tvm.schedule.ScheduleOps(s, bounds)
+stmt = tvm.ir_pass.LoopPartition(stmt)
+print(stmt)


we can assert the result AST
something like

str(stmt.condition) == xyz

tqchen · 2017-03-01T21:58:05Z

tests/python/unittest/test_pass_loop_partition.py

+bounds = tvm.schedule.InferBound(s)
+stmt = tvm.schedule.ScheduleOps(s, bounds)
+stmt = tvm.ir_pass.LoopPartition(stmt)
+print(stmt)


Let us also add end to end test cases, to test elementwise add and gemm, to make sure the result program looks correct

tqchen · 2017-03-01T22:04:11Z

src/pass/loop_partition.cc

+ public:
+  explicit LoopPartitioner() {}
+  Expr Mutate(Expr e) override {
+    return IRMutator::Mutate(e);


no need to override if there is no change

tqchen · 2017-03-03T17:53:04Z

src/pass/loop_partition.cc

+
+  void Visit_(const For* op) {
+    for (auto kv : out_vars_) {
+      if (ExprUseVar(op->min, kv.first) ||


consider make ExprUseVar take the map, so it is one pass cost

tqchen · 2017-03-03T17:54:43Z

src/pass/loop_partition.cc

+  using IRMutator::Mutate;
+
+ private:
+  const std::vector<Partition>& ps_;


map of Node*->Partition

avoids the linear search per expression

Do you want to remove struct Partition, use std::unordered_map<const Node*, Interval> directly?

I think Partition is good, if things might change in future

tqchen · 2017-03-03T17:55:23Z

src/pass/loop_partition.cc

+      return res;
+    }
+
+    PartitionFinder finder(op->loop_var, vars_);


move the subsequent logic to a separate function DoPartition

Or std::vector<Partition> FindPartitions(Expr target, std::unorder_map<const Variable*, IntSet>)? here do the real partition in fact

I think this is fine. The only thing is there is a check on whether you want to do partition or not, and we skipped the constant loops. So Have a function name can indicate here we really start to do partition

tqchen · 2017-03-03T17:56:23Z

src/pass/loop_partition.cc

+    Stmt s = simplified_stmt;
+
+    if (!can_prove(true_itrv.min() == universe.min())) {
+      Expr pre_doubt_cond = (true_itrv.min() != universe.min());


we don;t need to check this cond, since they are implicit in for loop and will be checked

tqchen · 2017-03-03T17:57:56Z

src/arithmetic/int_set.h

+ * \return the set after intersected
+ */
+IntSet Intersect(const Array<IntSet>& sets);
+IntSet Intersect(const std::vector<IntSet>& sets);


I think we can simply construct Array in outside and pass it in. Should be same as vector

tqchen · 2017-03-04T01:16:17Z

tests/python/unittest/test_arith_intset.py

@@ -16,17 +16,17 @@ def test_deduce():
    d_s = tvm.arith.intset_interval(-3, -1)

    e0 = (-b)*a+c-d
-    res0 = tvm.arith.DeduceBound(a, e0>=0, {b: b_s, c: c_s, d: d_s})
+    res0 = tvm.arith.DeduceBound(a, e0>=0, {b: b_s, c: c_s, d: d_s}, {})


Add a testcase where relax set is presented?

tqchen · 2017-03-04T01:16:29Z

tests/python/unittest/test_pass_loop_partition.py

+                tvm.make.IfThenElse(
+                    (i*m+j+k < n), tvm.make.Evaluate(m), tvm.make.Evaluate(n)))))
+    stmt = tvm.ir_pass.LoopPartition(stmt)
+    # assert(stmt.body.first.body.body.condition.value == 1)


add assert is good

tqchen · 2017-03-04T01:58:11Z

src/pass/loop_partition.cc

+  bool success = false;
+  PostOrderVisit(expr, [&vars, &success](const NodeRef& node) {
+    for (const Variable* v : vars) {
+      if (node.get() == v) {


use unordered_set<Variable*>

always think about time complexity, try use O(1) data structure when we can if it does not have to be O(n) cost

quite correct, I always not notice this

tqchen · 2017-03-04T01:59:07Z

src/pass/loop_partition.cc

+  return success;
+}
+
+inline bool IsConstDomain(Expr min, Expr extent) {


I think we can simply fold it in, since the expression is so simple and fit into oneline

tqchen · 2017-03-04T02:00:23Z

src/pass/loop_partition.cc

+};
+
+std::unordered_map<const Node*, Partition>
+FindPartitions(VarExpr target, Stmt body, std::unordered_map<const Variable*, IntSet> vars) {


Sorry I am being not clear here. I do not mean FindPartition should be a function, instead the insertPartition logic should be a single function

So the logic is check if there can be partition, call insertPartition

tqchen · 2017-03-04T03:26:24Z

src/pass/loop_partition.cc

+      return res;
+    }
+
+    Stmt s = DoPartition(op, stmt);


merge the logic

if (!is_const(op->min) || is_const(op->extent)) {
s = DoPartition()
if (s.defined()) return s;
}
the default logic

tqchen · 2017-03-04T03:27:25Z

src/pass/loop_partition.cc

+ private:
+  Stmt DoPartition(const For* op, const Stmt& stmt);
+
+  std::unordered_map<const Variable*, IntSet> vars_;


tqchen · 2017-03-04T03:27:57Z

src/pass/loop_partition.cc

+ public:
+  explicit PartitionFinder(VarExpr loop_var,
+    const std::unordered_map<const Variable*, IntSet>& vars)
+      : target_var_(loop_var), out_vars_(vars.size()), hint_map_(vars), relax_map_() {


no need to put relax map in the initializer

tqchen · 2017-03-04T03:28:15Z

src/pass/loop_partition.cc

+  explicit PartitionFinder(VarExpr loop_var,
+    const std::unordered_map<const Variable*, IntSet>& vars)
+      : target_var_(loop_var), out_vars_(vars.size()), hint_map_(vars), relax_map_() {
+        for (auto kv : vars) out_vars_.insert(kv.first);


const auto& kv :

tqchen · 2017-03-04T03:29:08Z

src/pass/loop_partition.cc

@@ -0,0 +1,203 @@
+/*!
+ *  Copyright (c) 2016 by Contributors


* upd * upd * upd

A few new fixes have gone into tvm/unity that would be useful for us to grab.

ZihengJiang added 4 commits February 27, 2017 03:22

loop_partition draft

4a31797

divide loop variable into constant domain and variable domain & consi…

5c95c6f

…der multiple partitions

process doubt interval

335a8ad

merge with master branch

9afb1e1

ZihengJiang commented Mar 1, 2017

View reviewed changes

tqchen reviewed Mar 1, 2017

View reviewed changes

ZihengJiang added 3 commits March 2, 2017 22:27

fix and refactor, add relax_map arg in BoundDeduce

266931c

fix testcase and comment

40c0b5f

rebase to zero, convert to SSA

63d3a7d

tqchen reviewed Mar 3, 2017

View reviewed changes

tqchen reviewed Mar 4, 2017

View reviewed changes

change the logic of generating loop code & fix issues

d7aba90

tqchen reviewed Mar 4, 2017

View reviewed changes

ZihengJiang added 2 commits March 4, 2017 02:43

add a testcase for relax map in deducebound && fix issues

e2b39b1

Merge branch 'master' into dev-clean

7aa642c

tqchen reviewed Mar 4, 2017

View reviewed changes

src/pass/loop_partition.cc Outdated

@@ -0,0 +1,203 @@

/*!

* Copyright (c) 2016 by Contributors

Copy link

Member

tqchen Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017

ZihengJiang added 3 commits March 4, 2017 04:20

clean code

b5786b5

const auto&

8d0bbd9

add test_multi_if

d2a90b2

tqchen approved these changes Mar 4, 2017

View reviewed changes

tqchen merged commit c8ebfbe into apache:master Mar 4, 2017

tqchen mentioned this pull request Mar 7, 2017

LoopPartition #46

Closed

2 tasks

ZihengJiang deleted the dev-clean branch April 19, 2017 20:43

tqchen pushed a commit to tqchen/tvm that referenced this pull request May 26, 2018

fix typo (apache#56)

fe1541b

tqchen pushed a commit that referenced this pull request May 29, 2018

fix typo (#56)

8928f4e

tqchen pushed a commit to tqchen/tvm that referenced this pull request Jul 6, 2018

fix typo (apache#56)

fa5c588

tqchen added a commit to tqchen/tvm that referenced this pull request Jul 12, 2018

[TOPI] Fix the CPU op perf (apache#56)

d267eb1

tqchen added a commit that referenced this pull request Jul 12, 2018

[TOPI] Fix the CPU op perf (#56)

0af7131

tqchen added a commit to tqchen/tvm that referenced this pull request Aug 4, 2018

[TOPI] Fix the CPU op perf (apache#56)

bc41013

sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018

fix typo (apache#56)

8586191

sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018

[TOPI] Fix the CPU op perf (apache#56)

3f68952

tqchen added a commit to tqchen/tvm that referenced this pull request Mar 29, 2020

[TOPI] Fix the CPU op perf (apache#56)

ea9e519

simplelins mentioned this pull request Sep 3, 2020

Performance step about memory reduced for sgx #6389

Closed

cyx-6 pushed a commit to cyx-6/tvm that referenced this pull request Jun 28, 2022

Compatibility for py3.6 - py3.10 (apache#56)

964c92a

junrushao added a commit to cyx-6/tvm that referenced this pull request Jul 4, 2022

Compatibility for py3.6 - py3.10 (apache#56)

e955f50

cyx-6 pushed a commit to cyx-6/tvm that referenced this pull request Jul 13, 2022

Compatibility for py3.6 - py3.10 (apache#56)

7e0708c

Hzfengsy pushed a commit to Hzfengsy/tvm that referenced this pull request Jul 30, 2022

Compatibility for py3.6 - py3.10 (apache#56)

aeadf59

yzh119 added a commit to yzh119/tvm that referenced this pull request Nov 22, 2022

[Feature] dim_order argument for reverse cache read/write (apache#56)

8f50568

* upd * upd * upd

vinx13 pushed a commit to vinx13/tvm that referenced this pull request Mar 27, 2023

[Unity] Merge with tvm/unity (apache#56)

c068f89

A few new fixes have gone into tvm/unity that would be useful for us to grab.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PASS]LoopPartition #56

[PASS]LoopPartition #56

ZihengJiang commented Feb 27, 2017 •

edited

Loading

ZihengJiang Mar 1, 2017

tqchen Mar 1, 2017

tqchen Mar 1, 2017

tqchen Mar 1, 2017

tqchen Mar 1, 2017

tqchen Mar 1, 2017

tqchen Mar 1, 2017

tqchen Mar 3, 2017

tqchen Mar 3, 2017

tqchen Mar 3, 2017

ZihengJiang Mar 3, 2017

tqchen Mar 3, 2017

tqchen Mar 3, 2017

ZihengJiang Mar 3, 2017

tqchen Mar 3, 2017

tqchen Mar 3, 2017

tqchen Mar 3, 2017

tqchen Mar 4, 2017

ZihengJiang Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

ZihengJiang Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

tqchen Mar 4, 2017

[PASS]LoopPartition #56

[PASS]LoopPartition #56

Conversation

ZihengJiang commented Feb 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZihengJiang commented Feb 27, 2017 •

edited

Loading