Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autotuning, broken in #7337 #7566

Merged
merged 2 commits into from Mar 5, 2021
Merged

Fix autotuning, broken in #7337 #7566

merged 2 commits into from Mar 5, 2021

Conversation

areusch
Copy link
Contributor

@areusch areusch commented Mar 2, 2021

Turns out we have no AutoTVM integration tests at main that actually assert on anything. Adding one and fixing my breakage.

Still TODO: need to fix test_tuning_gpu, which has been failing for some time now. I don't know how to do this and it would be great if someone familiar with CUDA could debug the error:

DEBUG    autotvm:tuner.py:163 No: 1     GFLOPS: 0.00/0.00       result: MeasureResult(costs=(InstantiationError('Traceback (most recent call last):\n  [bt] (4) /workspace/build/libtvm.so(TVMFuncCall+0x61) [0x7fd90af1c2f1]\n  [bt] (3) /workspace/build/libtvm.so(+0x78e326) [0x7fd90a1eb326]\n  [bt] (2) /workspace/build/libtvm.so(tvm::transform::SequentialNode::operator()(tvm::IRModule, tvm::transform::PassContext const&) const+0x3ed) [0x7fd90a1e885d]\n  [bt] (1) /workspace/build/libtvm.so(tvm::tir::transform::PrimFuncPassNode::operator()(tv
m::IRModule, tvm::transform::PassContext const&) const+0x55b) [0x7fd90a627c7b]\n  [bt] (0) /workspace/build/libtvm.so(+0x14bc1eb) [0x7fd90af191eb]\n  File "/workspace/python/tvm/_ffi/_ctypes/packed_func.py", line 81, in cfun\n    rv = local_pyfunc(*pyargs)\n  File "/workspace/python/tvm/autotvm/measure/measure_methods.py", line 741, in verify_pass\n    raise InstantiationError("Skipped because of invalid gpu kernel")\ntvm.autotvm.task.space.InstantiationError: Skipped because of invalid gpu kernel',),), error_no=1, all_cost=0.03403472900390625, timestamp=1614703720.5951383)   [('tile_f', [-1, 32, 4, 2]), ('tile_y', [-1, 5, 1, 1]), ('tile_x', [-1, 5, 1, 1]), ('tile_rc', [-1, 32, 2]), ('tile_ry', [-1, 1, 3]), ('tile_rx', [-1, 3, 1]), ('auto_unroll_max_step', 1500), ('unroll_explicit', 0)],None,4506777

@jwfromm @csullivan @tqchen

@areusch areusch marked this pull request as ready for review March 5, 2021 15:43
@areusch
Copy link
Contributor Author

areusch commented Mar 5, 2021

@tqchen @tmoreau89 I guess this is ready for merge, TODO in original PR note notwithstanding. merging it is better than not merging it, according to the CI.

@tqchen tqchen merged commit 7344b66 into apache:main Mar 5, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* Fix autotuning, broken in apache#7337

* retrigger CI, because I don't understand how it passed
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
* Fix autotuning, broken in apache#7337

* retrigger CI, because I don't understand how it passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants