-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce module_loader to AutoTVM. #7337
Conversation
@tmoreau89 do you have suggestions where to move the VTA hook? we can leave in default, but given we are introducing this hook it seems like a better idea to leave the default code loader as simple as possible. |
e6d3cbb
to
ba6fbad
Compare
* Prepares for autotuning with microTVM, and provides extension hook for VTA.
ba6fbad
to
7f60717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. This PR also simplifies the logic in run_through_rpc
.
The only nit I have might be the naming. The name code_loader
seems a bit confusing to me and I have no clue about what it is until reviewing the PR. Since this loader actually loads the compiled module, would module_loader
a better name for it? I meant, even the docstring of code_loader
says "loading the module to be timed".
@comaniac great point! I've updated code_loader to module_loader everywhere in this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
* Introduce code_loader to AutoTVM. * Prepares for autotuning with microTVM, and provides extension hook for VTA. * add vta hook * git-black * pylint * Add missing import * Fix import problem * add missing import * rename code_loader to module_loader * rename remote_kw to remote_kwargs * black format
* Introduce code_loader to AutoTVM. * Prepares for autotuning with microTVM, and provides extension hook for VTA. * add vta hook * git-black * pylint * Add missing import * Fix import problem * add missing import * rename code_loader to module_loader * rename remote_kw to remote_kwargs * black format
* Fix autotuning, broken in apache#7337 * retrigger CI, because I don't understand how it passed
* Fix autotuning, broken in apache#7337 * retrigger CI, because I don't understand how it passed
for VTA.