Introduce module_loader to AutoTVM. #7337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmoreau89 do you have suggestions where to move the VTA hook? we can leave in default, but given we are introducing this hook it seems like a better idea to leave the default code loader as simple as possible. |
areusch
force-pushed
the
autotvm-code-loader
branch
2 times, most recently
from
e6d3cbb
to
ba6fbad
Compare
* Prepares for autotuning with microTVM, and provides extension hook for VTA.
areusch
force-pushed
the
autotvm-code-loader
branch
from
ba6fbad
to
7f60717
Compare
comaniac
reviewed
Feb 23, 2021
There was a problem hiding this comment.
Overall LGTM. This PR also simplifies the logic in run_through_rpc.
The only nit I have might be the naming. The name code_loader seems a bit confusing to me and I have no clue about what it is until reviewing the PR. Since this loader actually loads the compiled module, would module_loader a better name for it? I meant, even the docstring of code_loader says "loading the module to be timed".
areusch
changed the title
|
@comaniac great point! I've updated code_loader to module_loader everywhere in this change. |
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Introduce code_loader to AutoTVM. * Prepares for autotuning with microTVM, and provides extension hook for VTA. * add vta hook * git-black * pylint * Add missing import * Fix import problem * add missing import * rename code_loader to module_loader * rename remote_kw to remote_kwargs * black format
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Introduce code_loader to AutoTVM. * Prepares for autotuning with microTVM, and provides extension hook for VTA. * add vta hook * git-black * pylint * Add missing import * Fix import problem * add missing import * rename code_loader to module_loader * rename remote_kw to remote_kwargs * black format
areusch
added a commit
to areusch/tvm
that referenced
this pull request
Mar 2, 2021
tqchen
pushed a commit
that referenced
this pull request
Mar 5, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Fix autotuning, broken in apache#7337 * retrigger CI, because I don't understand how it passed
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* Fix autotuning, broken in apache#7337 * retrigger CI, because I don't understand how it passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for VTA.