sort.cc added to runtime for nms compatability #7942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexanderSerov please resolve the lint error |
|
Update PR but it not solve the problem, checks locally. Can't understand what's wrong |
|
@AlexanderSerov please run clang-format-10 on |
|
@masahi I did so. This tool just delete a problem line and don't say why. Also I tried to make changes from different text redactors - the same. If you understand linting, can you resolve the issue instead of me as this will be a lot faster. This issues marked as contributors can make change. |
|
It is just complaining that file names are not sorted in alphabet order. |
|
@masahi Done. Thanks |
masahi
approved these changes
May 14, 2021
|
Thanks @AlexanderSerov |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* sort.cc added to runtime for nms compatability * remove include * fix clang lint * sort includes in alphabet order Co-authored-by: Alexander Serov <alexander@tech5.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* sort.cc added to runtime for nms compatability * remove include * fix clang lint * sort includes in alphabet order Co-authored-by: Alexander Serov <alexander@tech5.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort.cc added to wasn runtime for nms support
Solves this issue