-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always docker/build.sh with --no-cache. #8038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to remove a change which I think doesn't belong to this PR.
# As part of the build process, Zephyr needs to touch some symlinks in zephyr/misc/generated/syscalls_links (this path is relative to the | ||
# build directory for a project). Mark the zephyr installation world-writable since this is a docker | ||
# container | ||
chmod -R o+w ${ZEPHYR_PROJECT_PATH} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same from #8037 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooops, looks like i forgot to checkout. thanks!
* Almost every docker container starts with apt-get install foo bar * This is inherently not cacheable, meanwhile the lack of --no-cache has bitten nearly everyone I've talked to who's tried to rebuild. * Adding now to address this repeated problem.
0135357
to
29d8657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@areusch feel free to merge it - I just didn't merge because CI was still pending, but the contents of this specific PR are not really tested in CI here, so feel free to merge when you're happy to do so. |
Thanks @areusch! |
* Almost every docker container starts with apt-get install foo bar * This is inherently not cacheable, meanwhile the lack of --no-cache has bitten nearly everyone I've talked to who's tried to rebuild. * Adding now to address this repeated problem.
* Almost every docker container starts with apt-get install foo bar * This is inherently not cacheable, meanwhile the lack of --no-cache has bitten nearly everyone I've talked to who's tried to rebuild. * Adding now to address this repeated problem.
has bitten nearly everyone I've talked to who's tried to rebuild.