[TIR] Fix data dependent indexing when lowering TE to TIR #8217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A conversion pass was missing the recursive VisitExpr statement.
tqchen
approved these changes
Jun 8, 2021
|
Thanks Tristan for the fix! A takeaway here is that we should always prefer recursive visit by calling |
junrushao
approved these changes
Jun 8, 2021
|
Thanks @tkonolige @tqchen @Hzfengsy! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
A conversion pass was missing the recursive VisitExpr statement.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
A conversion pass was missing the recursive VisitExpr statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A conversion pass was missing the recursive VisitExpr statement.
@junrushao1994 @Hzfengsy @vinx13 @MasterJH5574 @tqchen