[PROFILING] Add json output to profiling reports #8503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdw-octoml
approved these changes
Jul 20, 2021
include/tvm/runtime/profiling.h
Outdated
| @@ -205,6 +205,28 @@ class ReportNode : public Object { | |||
| * `aggregate` is true. | |||
| */ | |||
| String AsTable(bool sort = true, bool aggregate = true) const; | |||
| /*! \brief Convert this report to json. | |||
| * | |||
| * Output json will be of this format: | |||
There was a problem hiding this comment.
My eyes :-) Would you mind pretty printing this JSON in the comment? It makes the format more readable.
There was a problem hiding this comment.
Also, recommend using JSON (not json) in the comments for the sake of the autogenerated documentation.
|
|
||
| .. code-block: | ||
|
|
||
| {"calls": |
There was a problem hiding this comment.
See comment on C++ above, would be great if this were pretty-printed for readability (in the comment itself, no need for the actual JSON output).
|
|
||
| .. code-block: | ||
|
|
||
| {"calls": |
There was a problem hiding this comment.
See comment on C++ above, would be great if this were pretty-printed for readability (in the comment itself, no need for the actual JSON output).
tkonolige
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
|
@mdwelsh Your comments have been addressed. |
tkonolige
requested review from
kazum,
liangfu,
masahi,
tmoreau89,
vinx13 and
ZihengJiang
as code owners
areusch
reviewed
Jul 23, 2021
areusch
approved these changes
Jul 23, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [PROFILING] Add json output to profiling reports * format json in comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [PROFILING] Add json output to profiling reports * format json in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is machine readable json output. It is not meant to be used as a serialization format.
@leandron @mdwelsh @masahi