Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm][TVMC] Add ROCm to the TVMC driver #8896

Merged
merged 4 commits into from Sep 2, 2021
Merged

[ROCm][TVMC] Add ROCm to the TVMC driver #8896

merged 4 commits into from Sep 2, 2021

Conversation

mvermeulen
Copy link
Contributor

Enable ROCm as device for TVMC.

@leandron leandron self-assigned this Sep 1, 2021
leandron
leandron approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvermeulen
Copy link
Contributor Author

Looks like I missed one of my local changes, to add session.rocm call. Will push update to the PR
cc: @leandron

@leandron
Copy link
Contributor

leandron commented Sep 1, 2021

Looks like I missed one of my local changes, to add session.rocm call. Will push update to the PR
cc: @leandron

Correct. Sorry I missed that.

@mvermeulen
Copy link
Contributor Author

I can see the Jenkins error but unclear if/what I need to change @masahi is there something here related to ROCm?

@masahi
Copy link
Member

masahi commented Sep 1, 2021

No this is a very annoying flaky test that has been happening a lot recently. Please try kicking the CI again.

@mvermeulen
Copy link
Contributor Author

Thanks, I may need assistance in restarting it. I don't use this jenkins enough to know how to restart.

@masahi
Copy link
Member

masahi commented Sep 1, 2021 •
edited

You can do rebase and push, this will cause a new CI job. I also look for a way to retrigger the CI myself.

cc @junrushao1994 Do you know how to launch a new CI job as an admin (PMC)?

@masahi masahi merged commit eaf888c into apache:main Sep 2, 2021
@mvermeulen mvermeulen deleted the tvmc_rocm branch September 2, 2021 14:58
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 2, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/onnx/sceloss
4e43297 
* main:
  [UnitTests][Contrib] Enable contrib tensorrt/coreml unit tests (apache#8902)
  [BUG] DataType Bug In SplitRel (apache#8899)
  Enable python debug runtime for exported network libraries (apache#8793)
  Set default value of p in LpPool as 2 (apache#8866)
  [Community] @Hzfengsy -> Committer (apache#8908)
  Trivial uTVM -> microTVM "spelling" fix to align with branding. (apache#8905)
  [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures (apache#8904)
  Move to new style issue template system (apache#8898)
  [Onnx] Support Negative Log Loss (apache#8872)
  [ROCm][TVMC] Add ROCm to the TVMC driver (apache#8896)
  fix error report on Store (apache#8895)
  [Docker] Re-enabled automatic --tty flag when running bash. (apache#8861)
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@mvermeulen @ylc
[ROCm][TVMC] Add ROCm to the TVMC driver (apache#8896)
a9f1cf0 
* Add ROCm to list of RPC clients.

* Add ROCm to list of TVMC devices.

* Enable ROCm by adding session call.
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@mvermeulen @ylc
[ROCm][TVMC] Add ROCm to the TVMC driver (apache#8896)
bb1b66a 
* Add ROCm to list of RPC clients.

* Add ROCm to list of TVMC devices.

* Enable ROCm by adding session call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandron leandron leandron approved these changes

@comaniac comaniac Awaiting requested review from comaniac

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@jwfromm jwfromm Awaiting requested review from jwfromm

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

Assignees

@leandron leandron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvermeulen @leandron @masahi