[Bugfix] Fix other div zero errors also in rewrite_simplify #8983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 8, 2021 09:08
syang-ng
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen,
vinx13 and
yzhliu
as code owners
vinx13
approved these changes
Sep 10, 2021
|
There are some flaky tests on CI, could you push again to retrigger CI? |
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 16, 2021
* main: (102 commits) Implementation of relay_to_tir target hook (apache#8423) [Onnx] Fix NLL Loss tests (apache#8971) [Bugfix] Fix other div zero errors also in rewrite_simplify (apache#8983) [ONNX] enable the onnx tests after PR apache#8274 merged (apache#9019) [Hexagon] Disable `thread_local` on Hexagon (apache#9025) [Hexagon] Allow undefined symbols in libtvm_runtime.so on Hexagon (apache#9024) [Onnx] Add momentum (apache#9000) fix (apache#9021) [Community] @AndrewZhaoLuo -> Reviewer (apache#9020) [Hexagon] Implement model launcher (apache#8986) [Relay][Pass] Add ExtractOperators pass (apache#8996) [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration (apache#8808) [ONNX] Add Einsum converter (apache#8985) Add standalone_crt/ to be part of the wheel package, when available. (apache#9005) [Relay] Remove memory planing from LowerTEPass (apache#8974) [Hexagon] Treat floats as float32 when passing args to offloaded kernels (apache#9010) [Runtime] Pipeline Executor Initial patch. (apache#8702) [Hexagon] `llvm-options` attribute is an array of strings (apache#9011) disable cuda int8 schedule for non-cuda gpu target (apache#9014) [Torch] Add an option to make imported models compatible with the Relay text parser (apache#9015) ...
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
) * fix div zero error in rewrite_simplify * update the style to fix ci error * remove useless code and comment * fix div zero error of mod, floordiv, floormod in rewrite_simplify * rewrite the test case of divison by zero to fix ci error * remove useless tab * retrigger ci * remove useless blank to retrigger ci
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
) * fix div zero error in rewrite_simplify * update the style to fix ci error * remove useless code and comment * fix div zero error of mod, floordiv, floormod in rewrite_simplify * rewrite the test case of divison by zero to fix ci error * remove useless tab * retrigger ci * remove useless blank to retrigger ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the bug reported in PR 8961, I find there are other three divisions in src/arith/rewrite_simplify.cc also don't check whether the divisor is 0.
Bug Description
Each line of
rewrite_simplifycan trigger the segmentation fault error.To fix these errors, I add three zero checks in operator
mod,floordiv,floormod. And I hope there will be no division by zero errors elsewhere :-)