Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Disable thread_local on Hexagon #9025

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[Hexagon] Disable thread_local on Hexagon #9025

merged 1 commit into from
Sep 16, 2021

Conversation

kparzysz-quic
Copy link
Contributor

This is specific to running code on hardware: libc++abi can create TLS keys with destructors in the libc++abi library. Despite that,
the library gets unloaded before the keys are destroyed, leading to a crash. Turning off the use of thread_local is a workaround for this.

This is specific to running code on hardware: libc++abi can create
TLS keys with destructors in the libc++abi library. Despite that,
the library gets unloaded before the keys are destroyed, leading
to a crash. Turning off the use of `thread_local` is a workaround
for this.
@kparzysz-quic kparzysz-quic requested a review from a team as a code owner September 15, 2021 21:03
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jroesch jroesch merged commit fd27aab into apache:main Sep 16, 2021
@kparzysz-quic kparzysz-quic deleted the hexagon-thread-local branch September 16, 2021 14:10
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 16, 2021
* main: (102 commits)
  Implementation of relay_to_tir target hook (apache#8423)
  [Onnx] Fix NLL Loss tests (apache#8971)
  [Bugfix] Fix other div zero errors also in rewrite_simplify (apache#8983)
  [ONNX] enable the onnx tests after PR apache#8274 merged (apache#9019)
  [Hexagon] Disable `thread_local` on Hexagon (apache#9025)
  [Hexagon] Allow undefined symbols in libtvm_runtime.so on Hexagon (apache#9024)
  [Onnx] Add momentum (apache#9000)
  fix (apache#9021)
  [Community] @AndrewZhaoLuo -> Reviewer (apache#9020)
  [Hexagon] Implement model launcher (apache#8986)
  [Relay][Pass] Add ExtractOperators pass (apache#8996)
  [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration (apache#8808)
  [ONNX] Add Einsum converter (apache#8985)
  Add standalone_crt/ to be part of the wheel package, when available. (apache#9005)
  [Relay] Remove memory planing from LowerTEPass  (apache#8974)
  [Hexagon] Treat floats as float32 when passing args to offloaded kernels (apache#9010)
  [Runtime] Pipeline Executor Initial patch. (apache#8702)
  [Hexagon] `llvm-options` attribute is an array of strings (apache#9011)
  disable cuda int8 schedule for non-cuda gpu target (apache#9014)
  [Torch] Add an option to make imported models compatible with the Relay text parser (apache#9015)
  ...
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
This is specific to running code on hardware: libc++abi can create
TLS keys with destructors in the libc++abi library. Despite that,
the library gets unloaded before the keys are destroyed, leading
to a crash. Turning off the use of `thread_local` is a workaround
for this.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
This is specific to running code on hardware: libc++abi can create
TLS keys with destructors in the libc++abi library. Despite that,
the library gets unloaded before the keys are destroyed, leading
to a crash. Turning off the use of `thread_local` is a workaround
for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants