[microTVM][AutoTVM] Fix autotvm bug and tests #9003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadh
requested review from
areusch,
comaniac,
jroesch,
junrushao,
kazum,
liangfu,
manupak,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
mehrdadh
force-pushed
the
fix_micro_autotvm
branch
from
cebcd29
to
06d7331
Compare
tkonolige
approved these changes
Sep 14, 2021
| @@ -162,7 +162,7 @@ | |||
| n_trial=num_trials, | |||
| measure_option=measure_option, | |||
| callbacks=[ | |||
| tvm.autotvm.callback.log_to_file("microtvm_autotune.log"), | |||
| tvm.autotvm.callback.log_to_file("microtvm_autotune.log.txt"), | |||
There was a problem hiding this comment.
Why the double extension here?
There was a problem hiding this comment.
to be consistent with cleanup step in doc stage:
tvm/tests/scripts/task_python_docs.sh
Line 31 in ff4bf3b
areusch
reviewed
Sep 14, 2021
| @@ -691,11 +691,13 @@ void RPCEndpoint::Init() { | |||
| * the key to modify their behavior. | |||
| */ | |||
| std::shared_ptr<RPCEndpoint> RPCEndpoint::Create(std::unique_ptr<RPCChannel> channel, | |||
| std::string name, std::string remote_key) { | |||
| std::string name, std::string remote_key, | |||
| TypedPackedFunc<void()> fshutdown) { | |||
There was a problem hiding this comment.
@tqchen this is needed when a Python-side session constructor may keep a reference to the underlying session. Does it make sense to you?
There was a problem hiding this comment.
TQ requests change to fcleanup
areusch
approved these changes
Sep 14, 2021
| @@ -143,6 +144,9 @@ def __exit__(self, exc_type, exc_value, exc_traceback): | |||
| """Tear down this session and associated RPC session resources.""" | |||
| self.transport.__exit__(exc_type, exc_value, exc_traceback) | |||
|
|
|||
| def _shutdown(self): | |||
| self.__exit__(None, None, None) | |||
There was a problem hiding this comment.
perhaps for a future cleanup: let's ensure we avoid double-calling __exit__ by checking some local var to determine whether we did already.
| @@ -190,6 +192,8 @@ class RPCEndpoint { | |||
| std::string name_; | |||
| // The remote key | |||
| std::string remote_key_; | |||
| // The shutdown Packed Function | |||
There was a problem hiding this comment.
nit: say something more like: "invoked when the RPC session is terminated"
areusch
pushed a commit
that referenced
this pull request
Sep 17, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* debuggging * cleanup and fix tutorial, zephyr and crt test * fix crt test * address comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* fix test and cleanup * fix tutorial doc * fix verbose for tutorial * fix tune check * address comments * address comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* debuggging * cleanup and fix tutorial, zephyr and crt test * fix crt test * address comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* fix test and cleanup * fix tutorial doc * fix verbose for tutorial * fix tune check * address comments * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microTVM autotvm is still broken and our zephyr/crt tests doesn't catch the error. This PR fixed the autotvm and change the tests to capture autotvm error.
cc @areusch @tkonolige