-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC] Fix DNNL Conv2D in JSON runtime #9043
Conversation
Thanks for the fix. Could you please finish the PR description and add a test case? |
@comaniac thanks for your reply. is there any guideline for |
Yes. Basically you just need to add a new test or improve an existing test that will fail without this PR, so that we could make sure the fix covered by this PR won't be broken in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The CI error seems not relevant so you probably need to just re-trigger it.
how to re-trigger CI? |
Just push an empty commit with --allow-empty. |
* dnnl memory dim is wrong for conv2d * change test case for dnnl conv2d * trigger CI Co-authored-by: sunway <sunwayforever@hotmail.com>
* dnnl memory dim is wrong for conv2d * change test case for dnnl conv2d * trigger CI Co-authored-by: sunway <sunwayforever@hotmail.com>
There are some typoes when handling conv2d shapes in dnnl. the original test
case doesn't cover conditions like conv2d with different input height/width, or
with different top/bottom padding.