Add cache flush for arm #9170
Merged
Add cache flush for arm #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
requested review from
areusch,
junrushao,
kazum,
liangfu,
masahi,
tmoreau89,
tqchen,
vinx13 and
ZihengJiang
as code owners
|
Yeah I believe the original author is @FrozenGene |
junrushao
approved these changes
Sep 30, 2021
|
Here is the original commit: 6308379dc71137d1ff8628ab1fb555f7a5770f45 |
tkonolige
force-pushed
the
arm_cache_flush
branch
from
6d36c3a
to
8fd5846
Compare
|
Thanks @tkonolige! This is merged :-) |
@junrushao1994 @tkonolige Yes. Some background, this is written originally by myself when I developed ansor. However, I found this doesn't have effect on the rasperry pi 3b+ like we gained on x86 at that time. So I don't upload the code to the upstream. @tkonolige Do you test it and find it has effect on your arm devices? |
FrozenGene
reviewed
Oct 8, 2021
| @@ -320,18 +320,33 @@ std::shared_ptr<RPCSession> RPCModuleGetSession(Module mod) { | |||
| * which leads to lower performance. | |||
| */ | |||
| inline void CPUCacheFlushImpl(const char* addr, unsigned int len) { | |||
| // TODO(FrozenGene): Support ARM. | |||
There was a problem hiding this comment.
Maybe we should leave this TODO as we haven't completed support for arm 32 bits.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Add cache flush for arm * formatting Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Add cache flush for arm * formatting Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a cache flush implementation for ARM. The code was written by @merrymercy for Tenset to improve accuracy of program measurement. I am just helping getting things upstreamed (with permission).
@junrushao1994 @merrymercy