Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cc bot skip errors #9988

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Make cc bot skip errors #9988

merged 2 commits into from
Jan 21, 2022

Conversation

driazati
Copy link
Member

@driazati driazati commented Jan 19, 2022

This adds some better logging and ignores errors (this job shouldn't ever show up as a PR failure) so we can diagnose things like https://github.com/apache/tvm/runs/4873810315?check_suite_focus=true

@driazati driazati marked this pull request as ready for review January 19, 2022 21:18
@github-actions github-actions bot removed the request for review from a team January 19, 2022 21:19
@driazati driazati changed the title Make cc bot skip errors [skip ci] Make cc bot skip errors Jan 19, 2022
@driazati driazati changed the title [skip ci] Make cc bot skip errors Make cc bot skip errors Jan 19, 2022
@driazati
Copy link
Member Author

Added a fix for the actual issue (see #9990)

@driazati driazati requested a review from jroesch January 19, 2022 22:09
This adds some better logging and ignores errors (this job shouldn't ever show up as a PR failure) so we can diagnose things like https://github.com/apache/tvm/runs/4873810315?check_suite_focus=true
@driazati driazati mentioned this pull request Jan 20, 2022
@masahi masahi merged commit 2426749 into apache:main Jan 21, 2022
yuanfz98 pushed a commit to yuanfz98/tvm that referenced this pull request Jan 24, 2022
* [skip ci] Make cc bot skip errors

This adds some better logging and ignores errors (this job shouldn't ever show up as a PR failure) so we can diagnose things like https://github.com/apache/tvm/runs/4873810315?check_suite_focus=true

* Submit cc'ed reviewers one at a time

Co-authored-by: driazati <driazati@users.noreply.github.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
* [skip ci] Make cc bot skip errors

This adds some better logging and ignores errors (this job shouldn't ever show up as a PR failure) so we can diagnose things like https://github.com/apache/tvm/runs/4873810315?check_suite_focus=true

* Submit cc'ed reviewers one at a time

Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants