This repository has been archived by the owner on May 12, 2021. It is now read-only.
(TWILL-187) Added max start time #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokulavasan
reviewed
Jan 7, 2017
| @@ -257,8 +258,19 @@ | |||
| TwillPreparer setLogLevels(String runnableName, Map<String, LogEntry.Level> logLevelsForRunnable); | |||
|
|
|||
| /** | |||
| * Starts the application. | |||
| * Starts the application. It's the same as calling {@link #start(long, TimeUnit)} with timeout of 60 seconds. | |||
There was a problem hiding this comment.
Is there any constant that we can refer to for '60' ?
There was a problem hiding this comment.
There is, however it's defined in the core module, hence can't refer to it in the API module
albertshau
approved these changes
Jan 7, 2017
|
For the stop timeout, it is cover by TWILL-192, as the changes are more complicate in the stop case |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.