This repository has been archived by the owner on May 12, 2021. It is now read-only.
(TWILL-177) Make ZKDiscoveryService AutoCloseable #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chtyim
commented
Aug 29, 2016
chtyim
commented
- Release ZK watches when closed
|
|
||
| @Before | ||
| public void beforeTest() { | ||
| LOG.info("Before test {}", testName.getMethodName()); |
There was a problem hiding this comment.
this was just for investigation? Can be removed now?
There was a problem hiding this comment.
Why? It helps identify which parts in the log is for which test.
There was a problem hiding this comment.
Wouldn't JUnit already log the test method before it is executed?
chtyim
force-pushed
the
feature/twill-177
branch
from
98bcb2d
to
9c0939f
Compare
|
Rebased on master and resolved conflicts. |
| import org.junit.Before; | ||
| import org.junit.Rule; | ||
| import org.junit.rules.ExternalResource; | ||
| import org.junit.rules.TestName; |
|
one minor comment, otherwise lgtm |
- Release ZK watches when closed
- Fixed a race condition in ZKDiscoveryServiceTest
- Fix the easy to fail InitializeFailTestRun
- Match with an error message emitted from AM instead of from the container.
- It’s possible that the one from the container don’t have chance to
send out before it gets killed.
chtyim
force-pushed
the
feature/twill-177
branch
from
0e9ef1b
to
170a729
Compare
|
Squashed commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.