Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIMA components log and then re-throw exceptions which usually leads to errors being logged twice #268

Closed
reckart opened this issue Dec 7, 2022 · 0 comments
Assignees
Labels
🦟 Bug Something isn't working
Milestone

Comments

@reckart
Copy link
Member

reckart commented Dec 7, 2022

Describe the bug
UIMA components log and then re-throw exceptions which usually leads to errors being logged twice:

  • first time by the UIMA component wrapper
  • then by the code that runs the component/pipeline

In particular in unit tests that intentionally trigger exceptions this is highly annoying as these exceptions logged on the error level are spamming the output and distract developers from other relevant exceptions.

To Reproduce

  • Build a component that throws an exception e.g. in the process method
  • Run that and catch exceptions and log them.

Expected behavior
At least this should be optional behavior used for cases where the runner code does not handle exceptions. However, to be honest, I believe if the runner code does not log exceptions produced by the components, then that is a problem in the runner code and not a thing the components should be concerned with.

Please complete the following information:

  • Version: 3.3.1
@reckart reckart added the 🦟 Bug Something isn't working label Dec 7, 2022
@reckart reckart added this to the 3.4.0 milestone Dec 7, 2022
@reckart reckart self-assigned this Dec 7, 2022
reckart added a commit that referenced this issue Jan 12, 2023
…ually leads to errors being logged twice

- Remove logging statement
reckart added a commit that referenced this issue Jan 12, 2023
…nd-then-re-throw-exceptions-which-usually-leads-to-errors-being-logged-twice

Issue #268: UIMA components log and then re-throw exceptions which usually leads to errors being logged twice
@reckart reckart closed this as completed Jan 12, 2023
reckart added a commit that referenced this issue Jan 13, 2023
…ntation-from-website-into-maintainer-guide

* main:
  Issue #265: Unable to release without auto-staging
  Issue #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  Issue #268: UIMA components log and then re-throw exceptions which usually leads to errors being logged twice
  Issue #272: select on FSArray seems broken
  Issue #275: Improved error message made it even more misleading
  Issue #266: Unable to install UIMA 3.3.1 Eclipse Plugins in Eclipse 2022-09
reckart added a commit that referenced this issue Jan 16, 2023
…ipse-plugins-during-release-builds

* main:
  Issue #265: Unable to release without auto-staging
  Issue #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  Issue #268: UIMA components log and then re-throw exceptions which usually leads to errors being logged twice
  Issue #272: select on FSArray seems broken
  Issue #275: Improved error message made it even more misleading
  Issue #266: Unable to install UIMA 3.3.1 Eclipse Plugins in Eclipse 2022-09
reckart added a commit that referenced this issue Jan 20, 2023
…-a-PEAR-context

* main: (91 commits)
  Issue #283: Update issue report generation
  Issue #283: Update issue report generation
  [UIMA-6436] Move maintainer documentation from website into maintainer guide
  [UIMA-6436] Move maintainer documentation from website into maintainer guide
  [UIMA-6436] Move maintainer documentation from website into maintainer guide
  Issue #265: Unable to release without auto-staging
  Issue #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  Issue #268: UIMA components log and then re-throw exceptions which usually leads to errors being logged twice
  Issue #275: Improved error message made it even more misleading
  Issue #266: Unable to install UIMA 3.3.1 Eclipse Plugins in Eclipse 2022-09
  No issue: Remove Jira line from PR template - we do not use Jira anymore.
  #270 - Update dependencies
  #270 - Update dependencies
  #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  No issue. Adjust jira legacy module version.
  Issue #252: Potential failure to look up FsGenerator3 in OSGI-like contexts
  Issue #225: Improve deployment in OSGi environments
  Issue #226: Provide SPI interfaces to locate descriptors and JCas classes
  Issue #226: Provide SPI interfaces to locate descriptors and JCas classes
  Issue #247 - RelativePathResolver should consider TCCL
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant