Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIMA Log4jLogger_impl not compatible with log4j 2.18.0+ #267

Closed
reckart opened this issue Dec 2, 2022 · 3 comments
Closed

UIMA Log4jLogger_impl not compatible with log4j 2.18.0+ #267

reckart opened this issue Dec 2, 2022 · 3 comments
Assignees
Labels
🦟 Bug Something isn't working
Milestone

Comments

@reckart
Copy link
Member

reckart commented Dec 2, 2022

Describe the bug
The class org.apache.logging.slf4j.Log4jMarker is no longer public in log4j versions >= 2.18.0

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade log4j dependency to 2.18.0 or higher
  2. Run de.tudarmstadt.ukp.clarin.webanno.api.type.CASMetadataTest

Expected behavior
Should work.

Please complete the following information:

  • Version: 3.3.1
@reckart reckart added the 🦟 Bug Something isn't working label Dec 2, 2022
@reckart reckart added this to the 3.3.2 milestone Dec 2, 2022
@reckart reckart self-assigned this Dec 2, 2022
reckart added a commit that referenced this issue Dec 7, 2022
- Use reflection to pry-open a protected class that was previously public - frankly, this is not a good solution...
reckart added a commit that referenced this issue Dec 7, 2022
…not-compatible-with-log4j-2.18.0

#267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
@reckart reckart modified the milestones: 3.3.2, 3.4.0 Dec 7, 2022
@reckart
Copy link
Member Author

reckart commented Dec 7, 2022

Added a nasty workaround using reflection. An alternative solution would be better....

reckart added a commit that referenced this issue Jan 11, 2023
…ntation-from-website-into-maintainer-guide

* main:
  No issue: Remove Jira line from PR template - we do not use Jira anymore.
  #270 - Update dependencies
  #270 - Update dependencies
  #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  No issue. Adjust jira legacy module version.
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release uimaj-3.3.1
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #260: Issues-fixed report for GitHub and Jira
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
reckart added a commit that referenced this issue Jan 11, 2023
…ipse-plugins-during-release-builds

* main: (94 commits)
  No issue: Remove Jira line from PR template - we do not use Jira anymore.
  #270 - Update dependencies
  #270 - Update dependencies
  #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  No issue. Adjust jira legacy module version.
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release uimaj-3.3.1
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #260: Issues-fixed report for GitHub and Jira
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #258: Apache UIMA Java SDK 3.3.1 release
  Issue #255: File handle leak accessing performanceTuning.properties
  Issue #252: Potential failure to look up FsGenerator3 in OSGI-like contexts
  Issue #225: Improve deployment in OSGi environments
  Issue #226: Provide SPI interfaces to locate descriptors and JCas classes
  Issue #226: Provide SPI interfaces to locate descriptors and JCas classes
  Issue #247 - RelativePathResolver should consider TCCL
  ...

% Conflicts:
%	uimaj-parent/pom.xml
reckart added a commit that referenced this issue Jan 12, 2023
- Use proper API instead of reflection to obtain the marker
reckart added a commit that referenced this issue Jan 12, 2023
…not-compatible-with-log4j-2.18.0

Issue #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
@reckart reckart closed this as completed Jan 12, 2023
reckart added a commit that referenced this issue Jan 13, 2023
…ntation-from-website-into-maintainer-guide

* main:
  Issue #265: Unable to release without auto-staging
  Issue #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  Issue #268: UIMA components log and then re-throw exceptions which usually leads to errors being logged twice
  Issue #272: select on FSArray seems broken
  Issue #275: Improved error message made it even more misleading
  Issue #266: Unable to install UIMA 3.3.1 Eclipse Plugins in Eclipse 2022-09
reckart added a commit that referenced this issue Jan 16, 2023
…ipse-plugins-during-release-builds

* main:
  Issue #265: Unable to release without auto-staging
  Issue #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  Issue #268: UIMA components log and then re-throw exceptions which usually leads to errors being logged twice
  Issue #272: select on FSArray seems broken
  Issue #275: Improved error message made it even more misleading
  Issue #266: Unable to install UIMA 3.3.1 Eclipse Plugins in Eclipse 2022-09
reckart added a commit that referenced this issue Jan 20, 2023
…-a-PEAR-context

* main: (91 commits)
  Issue #283: Update issue report generation
  Issue #283: Update issue report generation
  [UIMA-6436] Move maintainer documentation from website into maintainer guide
  [UIMA-6436] Move maintainer documentation from website into maintainer guide
  [UIMA-6436] Move maintainer documentation from website into maintainer guide
  Issue #265: Unable to release without auto-staging
  Issue #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  Issue #268: UIMA components log and then re-throw exceptions which usually leads to errors being logged twice
  Issue #275: Improved error message made it even more misleading
  Issue #266: Unable to install UIMA 3.3.1 Eclipse Plugins in Eclipse 2022-09
  No issue: Remove Jira line from PR template - we do not use Jira anymore.
  #270 - Update dependencies
  #270 - Update dependencies
  #267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+
  No issue. Adjust jira legacy module version.
  Issue #252: Potential failure to look up FsGenerator3 in OSGI-like contexts
  Issue #225: Improve deployment in OSGi environments
  Issue #226: Provide SPI interfaces to locate descriptors and JCas classes
  Issue #226: Provide SPI interfaces to locate descriptors and JCas classes
  Issue #247 - RelativePathResolver should consider TCCL
  ...
@DrZ7
Copy link

DrZ7 commented Feb 1, 2023

when will 3.3.2 be released?

@reckart
Copy link
Member Author

reckart commented Feb 1, 2023

Most likely never because we are currently voting on 3.4.0.

Feel free to join the user/dev mailing list. Btw. anybody can vote (non-binding) on a release - it is a good way to get involved and a good way to check if your environment works well with upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants