Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #226: Provide SPI interfaces to locate descriptors #237

Conversation

reckart
Copy link
Member

@reckart reckart commented Jul 29, 2022

What's in the PR

  • Added SPI for JCas classes
  • Added test that FSClassRegistry is able to load JCas classes through the SPI
  • Push exclusion of META-INF down into the bundle modules because we do not want to exclude the META-INF/services for SPI testing

How to test manually

  • No specific test procedure

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR includes new dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

- Added SPI for JCas classes
- Added test that FSClassRegistry is able to load JCas classes through the SPI
- Push exclusion of META-INF down into the bundle modules because we do not want to exclude the META-INF/services for SPI testing
@reckart reckart added the ⭐️ Enhancement Improvement or new feature for users label Jul 29, 2022
@reckart reckart added this to the 3.4.0 milestone Jul 29, 2022
@reckart reckart self-assigned this Jul 29, 2022
- When loading a class through an SPI, use its classloader for the generator lookup
- Add own type classes for SPI testing to avoid interfering with existing tests
- Exclude SPI control file from rat check
@reckart reckart merged commit bb48124 into main Aug 15, 2022
@reckart reckart deleted the feature/226-Provide-SPI-interfaces-to-locate-descriptors-and-JCas-classes branch August 15, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Enhancement Improvement or new feature for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant