Issue #226: Provide SPI interfaces to locate descriptors #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SPI for JCas classes - Added test that FSClassRegistry is able to load JCas classes through the SPI - Push exclusion of META-INF down into the bundle modules because we do not want to exclude the META-INF/services for SPI testing
- When loading a class through an SPI, use its classloader for the generator lookup - Add own type classes for SPI testing to avoid interfering with existing tests
- Update template
- Exclude SPI control file from rat check
- Added a bit of documentation
reckart
deleted the
feature/226-Provide-SPI-interfaces-to-locate-descriptors-and-JCas-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation
Organizational
Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.