Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#267 - UIMA Log4jLogger_impl not compatible with log4j 2.18.0+ #269

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 7, 2022

What's in the PR

  • Use reflection to pry-open a protected class that was previously public - frankly, this is not a good solution...

How to test manually

  • Upgrade to log42 2.18.0 and build
  • Upgrade to log42 2.18.0 and run with Java 17

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

- Use reflection to pry-open a protected class that was previously public - frankly, this is not a good solution...
@reckart reckart added the 🦟 Bug Something isn't working label Dec 7, 2022
@reckart reckart added this to the 3.4.0 milestone Dec 7, 2022
@reckart reckart self-assigned this Dec 7, 2022
@reckart reckart merged commit 1a9ca71 into main Dec 7, 2022
@reckart reckart deleted the bugfix/267-UIMA-Log4jLogger_impl-not-compatible-with-log4j-2.18.0 branch December 7, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant