WICKET-6528 Don't block user when component not on Page using AJAX #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-instate the behavior that was in versions < 8.0 that a component added to an AjaxRequestTarget but is not part of the page, would be ignored (or failed to refresh with an error in the JavaScript console). So instead of always throwing an error, we only do so in DEVELOPMENT mode causing an error page, and in DEPLOYMENT mode we only log the fault, but don't break the application hard for the user: the component refresh is ignored, just as it would've been in versions prior to 8. Fixes WICKET-6528
bitstorm
approved these changes
Feb 6, 2018
martin-g
approved these changes
Feb 6, 2018
klopfdreh
approved these changes
Mar 5, 2018
|
Is merged with commit 3be55cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-instate the behavior that was in versions < 8.0 that a component
added to an AjaxRequestTarget but is not part of the page, would be
ignored (or failed to refresh with an error in the JavaScript console).
So instead of always throwing an error, we only do so in DEVELOPMENT
mode causing an error page, and in DEPLOYMENT mode we only log the
fault, but don't break the application hard for the user: the component
refresh is ignored, just as it would've been in versions prior to 8.
Fixes WICKET-6528