Maven build improvements #119
Conversation
Also factor 4 identical classpaths out into property 'stylebook.classpath'.
|
Like I said on the mailing list, I just wanted to make the Maven build run and then noticed that there was no more error creating assemblies. So for now, I did not dig any deeper. I wanted your feedback first, focusing on solving any possible problems you are still encountering first, before eventually we might look into more cosmetical things - the proviso always being that I even have sparetime to look into it. |
|
Understood. Thanks for even the quick glance! I have a bit more fine tuning to do, and I may hit something unexpected, but it seems to basically be under control for now.
One oddity I did encounter: When the binary-assembly module was set to run as type pom. It seemed to be overwriting its own pom.xml with one of the archive files. For now I've worked around that by setting the output type to jar even though it shouldn't be producing a jarfile we need, but at some point I will have to understand why that was happening.
…--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() I still don't think HTML mail is a good idea
/\ but Outlook/Android is insisting. Need to
change mail client.
________________________________
From: Alexander Kriegisch ***@***.***>
Sent: Monday, November 13, 2023 8:55:18 PM
To: apache/xalan-java ***@***.***>
Cc: Joe Kesselman ***@***.***>; State change ***@***.***>
Subject: Re: [apache/xalan-java] Maven build improvements (PR #119)
Like I said on the mailing list, I just wanted to make the Maven build run and then noticed that there was no more error creating assemblies. So for now, I did not dig any deeper. I wanted your feedback first, focusing on solving any possible problems you are still encountering first, before eventually we might look into more cosmetical things - the proviso always being that I even have sparetime to look into it.
—
Reply to this email directly, view it on GitHub<#119 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6WZHEYG6CKQSS4GCOYTYELFQNAVCNFSM6AAAAAA7J7S22WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGQYTINJSG4>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
I suggest to make your parent POM just an aggregator with modules and not put any artifacts or artifact-creating plugins in there. It is better to create modules for things like docs generation or assembly building. Edit: I misunderstood. My advice, while correct, does not apply to your situation with the distribution, because you already created a separate module for it. After reading your comment without readying the code, I was under the impression that you would build the distribution from the parent POM. |
No, it does not overwrite the POM. I tried with your latest commit. Maybe in a previous version, you experimented with output directories or with special path and name for the dependency-reduced POM and accidentally ended up putting it into the base instead of the build directory. |
|
Thanks. Suspected that might be the case.
("Make it work. Make it good. Make it great." -- Steve Boies)
…--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() I still don't think HTML mail is a good idea
/\ but Outlook/Android is insisting. Need to
change mail client.
________________________________
From: Alexander Kriegisch ***@***.***>
Sent: Monday, November 13, 2023 9:52:53 PM
To: apache/xalan-java ***@***.***>
Cc: Joe Kesselman ***@***.***>; State change ***@***.***>
Subject: Re: [apache/xalan-java] Maven build improvements (PR #119)
I suggest to make your parent POM just an aggregator with modules and not put any artifacts or artifact-creating plugins in there. It is better to create modules for things like docs generation or assembly building.
—
Reply to this email directly, view it on GitHub<#119 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6W7GW2BTKDN62YMMWGDYELMIJAVCNFSM6AAAAAA7J7S22WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGQ3DGOJUHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Well... If I try to change distribution/pom.xml to The workaround of producing a near-empty jarfile is good enough for me, for now. But it would be good to understand whether the overwrite is a Maven/plugin bug (possibly because I'm loading an archaic version of something fixed long ago), or is me having done something stupid. |
* Reorganise .gitignore, add IntelliJ IDEA * Use platform-independent path separators in exec:exec * Also factor 4 identical classpaths out into property 'stylebook.classpath'.
exec:exec