Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YETUS-1224. 2023-05 Dependency Updates #305

Merged
merged 1 commit into from
May 23, 2023
Merged

YETUS-1224. 2023-05 Dependency Updates #305

merged 1 commit into from
May 23, 2023

Conversation

aw-was-here
Copy link
Contributor

No description provided.

@aw-was-here aw-was-here force-pushed the 2023-05-updates branch 3 times, most recently from 3d8ea5c to 05b5657 Compare May 21, 2023 22:28
ndimiduk
ndimiduk requested changes May 22, 2023
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number bumps look fine to me. It looks like you've also got some shellcheck nit cleanup mixed in though.

@aw-was-here
Copy link
Contributor Author

The version number bumps look fine to me. It looks like you've also got some shellcheck nit cleanup mixed in though.

Yeah, I needed the previous two commits in order to make this one even come close to passing. 😄 I'll rebase off of main and see what is left hanging out. I'm expecting some shellcheck changes still hanging around, but should be significantly less with the array conversion done.

@aw-was-here
Copy link
Contributor Author

I'm expecting some shellcheck changes still hanging around

So mostly handling shellcheck SC2317 warnings and the oddball echo escape and a one or two unquoted arguments. I'll leave it up to you @ndimiduk if you think any of those should get pulled out. Thanks!

@aw-was-here aw-was-here merged commit 73d9c82 into apache:main May 23, 2023
@aw-was-here aw-was-here deleted the 2023-05-updates branch May 23, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aw-was-here @ndimiduk