YETUS-896 Add an emoji column to the github vote table #67
Conversation
|
(!) A patch to the testing environment has been detected. |
|
👍 +1 overall
This message was automatically generated. |
|
The vote column seems redundant with the emoji maybe? Is it worth a cli option to pick between emoji + text vote or just text vote or just emoji for votes? Also should 0 votes have no emoji or perhaps a different one? |
I prefer to only use emoji. It is enough to show the vote result. |
|
Okay so how about an option that determines if the vote column is emoji or text? |
| else | ||
| echo "${TP_VOTE_TABLE[${i}]}" >> "${commentfile}" | ||
| echo "| :+1: ${TP_VOTE_TABLE[${i}]}" >> "${commentfile}" |
There was a problem hiding this comment.
There are three other values that need handling here, +0, -0, and 0. Marking them with the same emoji as +1 is very misleading.
There was a problem hiding this comment.
If we use different emoji for these vote. I thought we should use emoji + text vote both.
|
The complete list of github markdown emoji markup can be found in https://gist.github.com/rxaviers/7360908 |
Add a with-emoji option, if with-emoji, then use emoji and vote text both. If not, just use the vote text. |
|
(!) A patch to the testing environment has been detected. |
|
👍 +1 overall
This message was automatically generated. |
|
@busbey @aw-was-here Any more concerns? |
|
(!) A patch to the testing environment has been detected. |
|
👍 +1 overall
This message was automatically generated. |
|
Ping @busbey |
|
I agree that the emoji is duplicated with the vote. I suggested that, we can introduce an option called This is my implelmentation. I tried to use it in hbase first but it does not work... |
|
Closed in favor of #68 |
No description provided.