Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YETUS-916. upgrade golangci-lint and prototool; rm go cache #74

Merged
merged 1 commit into from Sep 30, 2019

Conversation

aw-was-here
Copy link
Contributor

No description provided.

@busbey
Copy link
Contributor

busbey commented Sep 30, 2019

this looks reasonable on the surface, but I don't have stuff on hand to test it. so weak 👍 ?

@apache-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-74/1/console in case of problems.

@aw-was-here
Copy link
Contributor Author

this looks reasonable on the surface, but I don't have stuff on hand to test it. so weak 👍 ?

In full disclosure, using that commit sha to build prototool from has some negatives to it and we'll almost certainly have to change it again soon. That said, most of those issues are related to how Go as a language community works (or, IMO, doesn't work).

In reality, I suspect most people are doing what I'm doing: creating a Dockerfile that FROM's apache/yetus:x.x.x and then replaces the Go bits with whatever actually works at that point in time.

@apache-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 33m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 32s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 9s the patch passed
+1 💚 hadolint 0m 3s There were no new hadolint issues.
+1 💚 shellcheck 0m 1s There were no new shellcheck issues.
+1 💚 shelldocs 0m 1s There were no new shelldocs issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 7s the patch passed
_ Other Tests _
+1 💚 unit 0m 8s precommit in the patch passed.
+1 💚 asflicense 0m 8s The patch does not generate ASF License warnings.
36m 35s
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-74/1/artifact/out/Dockerfile
GITHUB PR #74
Optional Tests dupname asflicense javac javadoc unit hadolint shellcheck shelldocs
uname Linux cb1835ea9356 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality precommit/src/main/shell/personality/yetus.sh
git revision master / 6b07c67
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/yetus-github-multibranch/job/PR-74/1/testReport/
Max. process+thread count 99 (vs. ulimit of 2000)
modules C: precommit U: precommit
Console output https://builds.apache.org/job/yetus-github-multibranch/job/PR-74/1/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.7.0 hadolint=1.16.2-0-g3b6f5a6
Powered by Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aw-was-here
Copy link
Contributor Author

Thanks for the review. I'm going to merge this now so that things aren't broken. :)

@aw-was-here aw-was-here merged commit b067f8e into apache:master Sep 30, 2019
@aw-was-here aw-was-here deleted the YETUS-916 branch September 30, 2019 15:58
busbey pushed a commit that referenced this pull request Oct 18, 2019
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit b067f8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants