Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-1754] Data race in TestStoreWithLimitedSize #550

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-1754] Data race in TestStoreWithLimitedSize #550

wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented May 19, 2023

What is this PR for?

Data race can occur in a TestStoreWithLimitedSize because the event publisher is not closed properly.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1754

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this May 19, 2023
craigcondit
craigcondit approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@pbacsko pbacsko deleted the YUNIKORN-1754 branch December 7, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcondit craigcondit craigcondit approved these changes

@wilfred-s wilfred-s Awaiting requested review from wilfred-s

@manirajv06 manirajv06 Awaiting requested review from manirajv06

Assignees

@pbacsko pbacsko

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pbacsko @craigcondit