[YUNIKORN-2652] Add Resource Usage details to getApplication endpoint #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to the getApplication webservice handler to provide expanded details about an application, including resource usage, if the `details=true` query parameter is specified on the endpoint request.
Add logic to the getApplication webservice handler to provide expanded details about an application, including resource usage, if the `details=true` query parameter is specified on the endpoint request.
…yunikorn-core into getapplication-resource-usage
Add logic to the getApplication webservice handler to provide expanded details about an application, including resource usage, if the `details=true` query parameter is specified on the endpoint request.
…yunikorn-core into getapplication-resource-usage
Add logic to the getApplication webservice handler to provide expanded details about an application, including resource usage, if the `details=true` query parameter is specified on the endpoint request.
…yunikorn-core into getapplication-resource-usage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
==========================================
- Coverage 78.52% 78.31% -0.22%
==========================================
Files 97 97
Lines 12206 12241 +35
==========================================
+ Hits 9585 9586 +1
- Misses 2323 2356 +33
- Partials 298 299 +1 ☔ View full report in Codecov by Sentry. |
pbacsko
requested changes
Jun 18, 2024
6 tasks
|
@richscott should this PR be closed and we continue with #897 ? |
I was out on holiday for the last two weeks - this other PR (#897) looks like it would work fine, I will close this PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
These changes enhance the
getApplication()function inpkg/webservice/to include some additional fields that may be valuable to users viewing completed applications - specifically, the response now includedStartTime,ResourceUsage,PreemptedResource, andPlaceholderResourcemembers.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2652
How should this be tested?
Any request to the endpoint(s) that use the
getApplication()function can be queried, with an additional boolean query parameter ofdetailsset to true, e.g.