[YUNIKORN-1559] Add a resource of pods=1 on all pods during scheduling
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
elihschiff
commented
Mar 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 69.71% 69.97% +0.26%
==========================================
Files 45 46 +1
Lines 7782 7881 +99
==========================================
+ Hits 5425 5515 +90
- Misses 2155 2163 +8
- Partials 202 203 +1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wilfred-s
requested changes
Mar 28, 2023
|
e2e failures are due to YUNIKORN-1666, need to re-run after that change is done before we commit |
|
Kicked off recheck as YUNIKORN-1666 is merged. |
wilfred-s
approved these changes
Mar 28, 2023
|
/recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In my cluster I am seeing occasional events like this on some of my pods which causes them to get stuck.
54m Warning OutOfpods pod/tg-spark-executor-640b4349263cc74570ae3a1e-0 Node didn't have enough resource: pods, requested: 1, used: 12, capacity: 12From what I can tell, nodes all have a
podsresource value on them. Because this value already exists on nodes, my PR adds a pods=1 value to add pods inside the scheduler. Then yunikorn uses the same resource scheduling logic used for memory, cpu, ect. to limit the number of pods running on a node.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1559
How should this be tested?
I am not 100% sure how best to test this. I fixed the tests including the e2e tests. I am testing this on my kubernetes clusters and it seems to have fixed the issue but I am not 100% sure if there is anything I should be worried about.
Screenshots (if appropriate)
Questions: