-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ZEPPELIN-2434] Credential feature does work in JDBC interpreter
### What is this PR for? Credential feature does not work in JDBC interpreter. This PR fixes unittest that does not detect this bug and fix jdbc interpreter to correctly read credential. ### What type of PR is it? Bug Fix ### Todos * [x] - Fix unittest * [x] - Fix condition when use credential, when use property. ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2434 ### How should this be tested? Set empty `default.user` property and set id/pw in 'credential' menu. And try use jdbc interpreter. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes #2269 from Leemoonsoo/jdbc_credential and squashes the following commits: 1de7ea6 [Lee moon soo] Use crednetial information instead of property when user is empty string.
- Loading branch information
1 parent
96de730
commit da793f3
Showing
2 changed files
with
14 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters