[ZEPPELIN-2434] Credential feature does work in JDBC interpreter #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
approved these changes
Apr 21, 2017
|
Merge to master and branch-0.7 if no further discussions. |
asfgit
pushed a commit
that referenced
this pull request
Apr 23, 2017
Credential feature does not work in JDBC interpreter. This PR fixes unittest that does not detect this bug and fix jdbc interpreter to correctly read credential. Bug Fix * [x] - Fix unittest * [x] - Fix condition when use credential, when use property. https://issues.apache.org/jira/browse/ZEPPELIN-2434 Set empty `default.user` property and set id/pw in 'credential' menu. And try use jdbc interpreter. * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes #2269 from Leemoonsoo/jdbc_credential and squashes the following commits: 1de7ea6 [Lee moon soo] Use crednetial information instead of property when user is empty string. (cherry picked from commit da793f3) Signed-off-by: Lee moon soo <moon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Credential feature does not work in JDBC interpreter.
This PR fixes unittest that does not detect this bug and fix jdbc interpreter to correctly read credential.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2434
How should this be tested?
Set empty
default.userproperty and set id/pw in 'credential' menu. And try use jdbc interpreter.Questions: