Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEPPELIN-992 Move some tests from InterpreterFactoryTest to LazyOpenInterpreterTest #1002

Closed
wants to merge 2 commits into from
Closed

ZEPPELIN-992 Move some tests from InterpreterFactoryTest to LazyOpenInterpreterTest #1002

wants to merge 2 commits into from

Conversation

jongyoul
Copy link
Member

What is this PR for?

Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to #987 a little bit.

What type of PR is it?

[Refactoring]

Todos

  • - Divide tests

What is the Jira issue?

How should this be tested?

Changed only test case

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul
Copy link
Member Author

The failures is related to ZEPPELIN-878

@jongyoul jongyoul closed this Jun 13, 2016
@jongyoul jongyoul reopened this Jun 13, 2016
@bzz
Copy link
Member

bzz commented Jun 13, 2016 •
edited

@jongyoul there are 3 CI failures here:

1 & 2

https://s3.amazonaws.com/archive.travis-ci.org/jobs/137185635/log.txt and https://s3.amazonaws.com/archive.travis-ci.org/jobs/137185637/log.txt

looks like a timeout on reaching out remote interpreter process.
Quickly glancing at list of open flaky-tests in JIRA it may be that we had it before under ZEPPELIN-862, so adding these guys there.

3

https://s3.amazonaws.com/archive.travis-ci.org/jobs/137185641/log.txt
Last CI failure I can see does not seem to be part of any existing open sub-task in ZEPPELIN-878

org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@class='modal-dialog'][contains(.,'Do you want to update this interpreter and restart with new settings?')]//div[@class='modal-footer']//button[contains(.,'OK')]"}

It looks like ZeppelinIT.testSparkInterpreterDependencyLoading#210 should have a confirmation modal dialog on interpreter page, but it's not showing up, according to screenshot below

screen shot 2016-06-13 at 18 49 50

@jongyoul jongyoul closed this Jun 13, 2016
@jongyoul jongyoul reopened this Jun 13, 2016
@jongyoul
Copy link
Member Author

@bzz Thanks for the guide. I'm good at selenium, thus I thought ZeppelinIT.testSparkInterpreterDependencyLoading was related to that issue. I'll look into it but do you know how to reproduce or why it occurs? I re-triggered it and passed all tests.

@jongyoul jongyoul changed the title ZEPPELIN-992 ZEPPELIN-992 Move some tests from InterpreterFactoryTest to LazyOpenInterpreterTest Jun 13, 2016
Leemoonsoo
Leemoonsoo reviewed Jun 13, 2016
View reviewed changes
zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/LazyOpenInterpreterTest.java
import static org.mockito.Mockito.when;

/**
* Created by jl on 6/13/16.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like an auto generated comment from some ide.
Could you take care of this comment to not include author?

@bzz
Copy link
Member

bzz commented Jun 15, 2016 •
edited

Looks great to me and CI passes now. Shall we merge this guy?

@asfgit asfgit closed this in 020e0e7 Jun 15, 2016
asfgit pushed a commit that referenced this pull request Jun 15, 2016
@jongyoul
ZEPPELIN-992 Move some tests from InterpreterFactoryTest to LazyOpenI…
ee7ebca 
…nterpreterTest

### What is this PR for?
Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to #987 a little bit.

### What type of PR is it?
[Refactoring]

### Todos
* [x] - Divide tests

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-992

### How should this be tested?
Changed only test case

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <jongyoul@gmail.com>

Closes #1002 from jongyoul/ZEPPELIN-992 and squashes the following commits:

da851da [Jongyoul Lee] Removed author tag
8ef2be3 [Jongyoul Lee] Moved Interpreter.interpret into LazyOpenInterpreterTest
AhyoungRyu pushed a commit to AhyoungRyu/zeppelin that referenced this pull request Jun 15, 2016
@jongyoul @AhyoungRyu
ZEPPELIN-992 Move some tests from InterpreterFactoryTest to LazyOpenI…
adf9853 
…nterpreterTest

### What is this PR for?
Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to apache#987 a little bit.

### What type of PR is it?
[Refactoring]

### Todos
* [x] - Divide tests

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-992

### How should this be tested?
Changed only test case

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <jongyoul@gmail.com>

Closes apache#1002 from jongyoul/ZEPPELIN-992 and squashes the following commits:

da851da [Jongyoul Lee] Removed author tag
8ef2be3 [Jongyoul Lee] Moved Interpreter.interpret into LazyOpenInterpreterTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jongyoul @bzz @Leemoonsoo