ZEPPELIN-694 Remove remote option on InterpreterOption #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongyoul
changed the title
| // angularObjectRegistryListener); | ||
| // | ||
| // // TODO(moon) : create distributed resource pool for local interpreters and set | ||
| // } |
There was a problem hiding this comment.
instead of commenting out, why not remove them?
There was a problem hiding this comment.
@felixcheung Even though github shows the changes but I thought it's easy to find out what the changes are. I'll remove them after review.
1 task
| @@ -21,7 +21,7 @@ | |||
| * | |||
| */ | |||
| public class InterpreterOption { | |||
| boolean remote; | |||
| boolean remote = false; | |||
There was a problem hiding this comment.
I think default value should be 'true' to allow previous version of zeppelin work with it.
There was a problem hiding this comment.
@Leemoonsoo My mistake.
asfgit
pushed a commit
that referenced
this pull request
Jun 15, 2016
…nterpreterTest ### What is this PR for? Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to #987 a little bit. ### What type of PR is it? [Refactoring] ### Todos * [x] - Divide tests ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-992 ### How should this be tested? Changed only test case ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes #1002 from jongyoul/ZEPPELIN-992 and squashes the following commits: da851da [Jongyoul Lee] Removed author tag 8ef2be3 [Jongyoul Lee] Moved Interpreter.interpret into LazyOpenInterpreterTest
asfgit
pushed a commit
that referenced
this pull request
Jun 15, 2016
…nterpreterTest ### What is this PR for? Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to #987 a little bit. ### What type of PR is it? [Refactoring] ### Todos * [x] - Divide tests ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-992 ### How should this be tested? Changed only test case ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes #1002 from jongyoul/ZEPPELIN-992 and squashes the following commits: da851da [Jongyoul Lee] Removed author tag 8ef2be3 [Jongyoul Lee] Moved Interpreter.interpret into LazyOpenInterpreterTest
Reverted remote option and marked deprecated
AhyoungRyu
pushed a commit
to AhyoungRyu/zeppelin
that referenced
this pull request
Jun 15, 2016
…nterpreterTest ### What is this PR for? Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to apache#987 a little bit. ### What type of PR is it? [Refactoring] ### Todos * [x] - Divide tests ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-992 ### How should this be tested? Changed only test case ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes apache#1002 from jongyoul/ZEPPELIN-992 and squashes the following commits: da851da [Jongyoul Lee] Removed author tag 8ef2be3 [Jongyoul Lee] Moved Interpreter.interpret into LazyOpenInterpreterTest
|
I'll make a new PR after I finish some preceding tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Removing some redundant codes for simplifying Zeppelin.
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Users must be able to use Zeppelin without any changes
Screenshots (if appropriate)
Questions: