Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1064] Flaky Test - ParagraphActionsIT.testTitleButton #1092

Closed
wants to merge 4 commits into from

Conversation

prabhjyotsingh
Copy link
Contributor

What is this PR for?

This is fix for test failing in CI

testTitleButton(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 11.11 sec  <<< FAILURE!
java.lang.AssertionError: After Show Title : The title field contains
Expected: "Untitled"
     but: was ""
    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    at org.junit.Assert.assertThat(Assert.java:865)
    at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
    at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
    at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
    at org.apache.zeppelin.integration.ParagraphActionsIT.testTitleButton(ParagraphActionsIT.java:350)

What type of PR is it?

[Bug Fix | Test]

Todos

  • - add delay before checking the values

What is the Jira issue?

How should this be tested?

CI should be green

Questions:

  • Does the licenses files need update? n/a
  • Is there breaking changes for older versions? n/a
  • Does this needs documentation? n/a

@bzz
Copy link
Member

bzz commented Jun 27, 2016

CI passes now, and changes looks great to me.

Let's merge if there is no further discussion

@Leemoonsoo
Copy link
Member

Thanks @prabhjyotsingh taking care of it. LGTM

@asfgit asfgit closed this in 4b63867 Jun 27, 2016
@prabhjyotsingh prabhjyotsingh deleted the ZEPPELIN-1064 branch February 25, 2018 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants