[ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just refactor NoteInterpreter to merge into InterpreterFactory. Could you please rebase it to resolve conflict? |
|
This PR is temporarily closed, While I refactor my codes. |
|
@mwkang You don't need to close this PR if you want to reopen after just refactoring your code :) TODO
and also the title to "[WIP][ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name"? |
|
@AhyoungRyu Thanks for your advice. Next time, I will try to do that. |
asfgit
pushed a commit
that referenced
this pull request
Sep 2, 2016
…rpreter name ### What is this PR for? Ignore implicit interpreter when user enter wrong interpreter name linked to #806 (comment) This PR is related to #1113 ZEPPELIN-1069 branch was force push, so couldn't reopen that PR. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1069 ### How should this be tested? Unit test Run-time checking ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Minwoo Kang <minwoo.kang@outlook.com> Closes #1248 from mwkang/ZEPPELIN-1069 and squashes the following commits: 3976a96 [Minwoo Kang] Remove wild card import fa7a194 [Minwoo Kang] Fix CI failed f0eedeb [Minwoo Kang] Remove unnecessary method. 6e91dfe [Minwoo Kang] Remove unnecessary method. dd60d72 [Minwoo Kang] Fixed CI 046f5f4 [Minwoo Kang] Modify static import position. 6082e28 [Minwoo Kang] Modify that StringUtils is static import 02a1c2a [Minwoo Kang] Refactor method name 4912c5c [Minwoo Kang] Add test cases b6520be [Minwoo Kang] Add function that is replName is binding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Ignore implicit interpreter when user enter wrong interpreter name
linked to #806 (comment)
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1069
How should this be tested?
unit test
Run-time checking
Questions: