New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name #1248
Conversation
@jongyoul Can you review this PR? |
@@ -1088,7 +1088,10 @@ private InterpreterSetting getDefaultInterpreterSetting(List<InterpreterSetting> | |||
public InterpreterSetting getDefaultInterpreterSetting(String noteId) { | |||
return getDefaultInterpreterSetting(getInterpreterSettings(noteId)); | |||
} | |||
|
|||
|
|||
public boolean isBinding(String noteId, String replName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would isBinded()
make more sense as a name for a method that checks weather a particular note is binded (bound) to a particular interpreter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree with you. Thanks for comments.
I will change method name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzz I want to ask your opinion. If I make Note#isBinding
method, I remove InterpreterFactory#isBinded
method. Do you agree with me?
Um.. Sorry I thinks that Keeping both methods is better.
👍 for having a test! Looks good to me, modulo the issue raised above. @mwkang can you take a look please? |
tested. LGTM |
I refactor method name. |
Yes, that is exactly what I meant @mwkang ! What do you think? |
@bzz I'm worried about that |
@bzz I changed StringUtils is static import. Can you check the code? |
@@ -17,6 +17,8 @@ | |||
|
|||
package org.apache.zeppelin.notebook; | |||
|
|||
import static org.apache.commons.lang.StringUtils.*; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static import statement is located at the end of all imports statements. Could you please move it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jongyoul Oh sorry, I move static import position.
Thanks for review.
Do you check the error of CI?
I think it's meaningful error and it needs to be fixed. |
@jongyoul Sorry, I missed it. I will check. I appreciate your review. |
re-trigger CI |
I am not sure this error is related with this issue.
|
@mwkang thank you for prompt addressing reviews! If you re-trigger CI more (close&re-open this PR) - does the same issue persists every time? |
@@ -1088,7 +1088,10 @@ private InterpreterSetting getDefaultInterpreterSetting(List<InterpreterSetting> | |||
public InterpreterSetting getDefaultInterpreterSetting(String noteId) { | |||
return getDefaultInterpreterSetting(getInterpreterSettings(noteId)); | |||
} | |||
|
|||
|
|||
public boolean isBinded(String noteId, String replName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed now, in favor of Note.isBinded()
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will remove it.
I'm not sure if it persists. I will re-tigger after fix the issue. |
@bzz No, It does not persists every time. |
Ok, good to know, let me look into that |
This looks like an issue fixed in master 10h ago:
Could you please try rebasing on latest master |
@bzz Thanks for your review. I rebase on to master and force push. |
Thank you! BTW in my experience, if in case of CI failure PR author posts the failure result from logs - that speeds us review a lot! CI fails now on Spark 1.6 Scala 2.10 and Scala 2.11 profiles with
Which seems to be networking issue on Travis side 😒 Thank you @mwkang for contribution, looks great to me, merging to master if there is no further discussion. |
@bzz I think This PR have some trouble merging to master. |
@mwkang thank you for friendly ping! |
@@ -56,6 +55,8 @@ | |||
import org.apache.zeppelin.user.AuthenticationInfo; | |||
import org.apache.zeppelin.user.Credentials; | |||
|
|||
import static org.apache.commons.lang.StringUtils.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per project styleguide#s3.3.1-wildcard-imports - could you please replace whiledcard imports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzz I'm sorry. I removed wild card import.
Thank you for your patience @mwkang ! Will merge to master asap, right after that, if there is no further discussion! |
ping @bzz |
I'm sorry for delay, @mwkang - my plate was full last week. |
What is this PR for?
Ignore implicit interpreter when user enter wrong interpreter name
linked to #806 (comment)
This PR is related to #1113
ZEPPELIN-1069 branch was force push, so couldn't reopen that PR.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1069
How should this be tested?
Unit test
Run-time checking
Screenshots (if appropriate)
Questions: