-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-1217] Remove horizontal scrollbar in Zeppelin conf table #1241
Conversation
@zjffdu Could you review this PR as a reporter? |
@AhyoungRyu I follow the instruction here to build the doc https://github.com/apache/zeppelin/blob/master/docs/README.md#build-documentation, but fails. Here's the error after
I ran it on mac os 10.11, and also did |
@zjffdu Did you run |
yes, I run it under |
@zjffdu I'm not sure, your issue is related with this issue, but could you try
|
Thanks @AhyoungRyu , the new UI lgtm. BTW, this link helps me in case someone else need this, |
@zjffdu Yeah I also struggled with ruby and my OSX version issues. Anyway thanks for providing the link :) |
2c82252
to
eb96fc4
Compare
Is this good to go now? |
LGTM 😄 |
LGTM, could be good to try changing that Table by something more descriptive. |
@corneadoug I'm not sure I got your point correctly, This short sentence is written in the above of the table. So do you mean this sentence is not enough? Or do you want me to add more description to the |
@AhyoungRyu Just pointing out that using a Table component to show the config variable isn't great. |
Merging if there is no more discussions |
What is this PR for?
This PR will fix ZEPPELIN-1217.
Current Zeppelin configuration table is hard to compare the env variable name with the descriptions at a glance because of the horizontal scrollbar. So I just removed the scrollbar.
What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-1217
Screenshots (if appropriate)
Questions: