Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1217] Remove horizontal scrollbar in Zeppelin conf table #1241

Closed
wants to merge 1 commit into from

Conversation

AhyoungRyu
Copy link
Contributor

What is this PR for?

This PR will fix ZEPPELIN-1217.

Current Zeppelin configuration table is hard to compare the env variable name with the descriptions at a glance because of the horizontal scrollbar. So I just removed the scrollbar.

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-1217

Screenshots (if appropriate)

  • Before
    before
  • After
    after

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Contributor Author

@zjffdu Could you review this PR as a reporter?

@zjffdu
Copy link
Contributor

zjffdu commented Jul 29, 2016

@AhyoungRyu I follow the instruction here to build the doc https://github.com/apache/zeppelin/blob/master/docs/README.md#build-documentation, but fails. Here's the error after bundle install

Using bundler 1.12.5
An error occurred while installing RedCloth (4.2.9), and Bundler cannot continue.
Make sure that `gem install RedCloth -v '4.2.9'` succeeds before bundling.

I ran it on mac os 10.11, and also did xcode-select --install, do you know how can I fix this ? Thanks

@AhyoungRyu
Copy link
Contributor Author

@zjffdu Did you run bundle install under ZEPPELIN_HOME/docs dir?

@zjffdu
Copy link
Contributor

zjffdu commented Jul 29, 2016

yes, I run it under ZEPPELIN_HOME/docs

@AhyoungRyu
Copy link
Contributor Author

AhyoungRyu commented Jul 29, 2016

@zjffdu I'm not sure, your issue is related with this issue, but could you try

gem uninstall bundler
sudo gem install bundler

@zjffdu
Copy link
Contributor

zjffdu commented Aug 1, 2016

Thanks @AhyoungRyu , the new UI lgtm. BTW, this link helps me in case someone else need this,
http://pragmaticstudio.com/blog/2010/9/23/install-rails-ruby-mac

@AhyoungRyu
Copy link
Contributor Author

@zjffdu Yeah I also struggled with ruby and my OSX version issues. Anyway thanks for providing the link :)

@AhyoungRyu AhyoungRyu closed this Aug 1, 2016
@AhyoungRyu AhyoungRyu reopened this Aug 1, 2016
@AhyoungRyu
Copy link
Contributor Author

Is this good to go now?

@zjffdu
Copy link
Contributor

zjffdu commented Aug 26, 2016

LGTM 😄

@corneadoug
Copy link
Contributor

LGTM, could be good to try changing that Table by something more descriptive.
Although the fact that there is 2 different configuration files with possible exclusive configurations doesn't help.

@AhyoungRyu
Copy link
Contributor Author

@corneadoug I'm not sure I got your point correctly,
"You can configure Apache Zeppelin with both environment variables in conf/zeppelin-env.sh (conf\zeppelin-env.cmd for Windows) and Java properties in conf/zeppelin-site.xml. If both are defined, then the environment variables will take priority."

This short sentence is written in the above of the table. So do you mean this sentence is not enough? Or do you want me to add more description to the Description column?

@corneadoug
Copy link
Contributor

@AhyoungRyu Just pointing out that using a Table component to show the config variable isn't great.

@corneadoug
Copy link
Contributor

Merging if there is no more discussions

@asfgit asfgit closed this in dad72ce Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants