Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-1326: make profile to select dependency of hadoop-common for JDBC interpreter #1380

Closed
wants to merge 5 commits into from

Conversation

prabhjyotsingh
Copy link
Contributor

What is this PR for?

Extension of #1353

java.lang.ClassNotFoundException: org.apache.hadoop.security.UserGroupInformation$AuthenticationMethod error on using jdbc interpreter after #1205

java.lang.ClassNotFoundException: org.apache.hadoop.security.UserGroupInformation$AuthenticationMethod
    at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
    at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
    at org.apache.zeppelin.jdbc.security.JDBCSecurityImpl.getAuthtype(JDBCSecurityImpl.java:71)
    at org.apache.zeppelin.jdbc.JDBCInterpreter.getConnection(JDBCInterpreter.java:217)
    at org.apache.zeppelin.jdbc.JDBCInterpreter.getStatement(JDBCInterpreter.java:275)
    at org.apache.zeppelin.jdbc.JDBCInterpreter.executeSql(JDBCInterpreter.java:346)
    at org.apache.zeppelin.jdbc.JDBCInterpreter.interpret(JDBCInterpreter.java:452)
    at org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:94)
    at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:383)
    at org.apache.zeppelin.scheduler.Job.run(Job.java:176)
    at org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

Workaround is adding "org.apache.hadoop:hadoop-common:2.7.2" in the Dependencies section of interpreter setting on GUI. But jdbc interpreter supposed to work without asking user hadoop-common dependency.

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

On running this (JDBC) interpreter, the above stack trace should not come.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? n/a
  • Is there breaking changes for older versions? n/a
  • Does this needs documentation? n/a

@jongyoul
Copy link
Member

@prabhjyotsingh I don't think it's necessary to set hadoop version because the dependencies are provided, and I don't think you need to change pom.xml in your PR. How do you think of it?

@prabhjyotsingh
Copy link
Contributor Author

Can you share the recommended changes diff ?

I originally thought to move repetitive pom.xml from spark and spark-dependency to parent, which can be used by all.

@prabhjyotsingh prabhjyotsingh changed the title Zeppelin 1326 ZEPPELIN-1326: make profile to select dependency of hadoop-common for JDBC interpreter Aug 29, 2016
@@ -74,7 +74,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<version>2.7.2</version>
<version>${hadoop.version}</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you revert this and undo all of pom.xml. How do you think of it?

@prabhjyotsingh
Copy link
Contributor Author

@jongyoul Sure, I see your point, and it make sense as well. Thank you for pointing it out.

@jongyoul
Copy link
Member

@prabhjyotsingh Thanks. @Leemoonsoo Could you please test it or tell me the step you tested?

@Leemoonsoo
Copy link
Member

Leemoonsoo commented Sep 1, 2016

@jongyoul Configure a jdbc interpreter (e.g. with mysql:mysql-connector-java:5.1.38 on it's dependency) and try to use it, following the official documentation. Then you can see the error.

I have tested the last commit and the error has gone. Looks good to me.

@jongyoul
Copy link
Member

jongyoul commented Sep 1, 2016

@Leemoonsoo I'll look into it.

@jongyoul
Copy link
Member

jongyoul commented Sep 6, 2016

@Leemoonsoo I've misunderstood your comment. LGTM. Merging if there's no more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants