-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZEPPELIN-1326: make profile to select dependency of hadoop-common for JDBC interpreter #1380
Conversation
@prabhjyotsingh I don't think it's necessary to set hadoop version because the dependencies are provided, and I don't think you need to change pom.xml in your PR. How do you think of it? |
Can you share the recommended changes diff ? I originally thought to move repetitive pom.xml from spark and spark-dependency to parent, which can be used by all. |
@@ -74,7 +74,7 @@ | |||
<dependency> | |||
<groupId>org.apache.hadoop</groupId> | |||
<artifactId>hadoop-common</artifactId> | |||
<version>2.7.2</version> | |||
<version>${hadoop.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you revert this and undo all of pom.xml. How do you think of it?
@jongyoul Sure, I see your point, and it make sense as well. Thank you for pointing it out. |
@prabhjyotsingh Thanks. @Leemoonsoo Could you please test it or tell me the step you tested? |
@jongyoul Configure a jdbc interpreter (e.g. with I have tested the last commit and the error has gone. Looks good to me. |
@Leemoonsoo I'll look into it. |
@Leemoonsoo I've misunderstood your comment. LGTM. Merging if there's no more discussion. |
What is this PR for?
Extension of #1353
java.lang.ClassNotFoundException: org.apache.hadoop.security.UserGroupInformation$AuthenticationMethod error on using jdbc interpreter after #1205
Workaround is adding "org.apache.hadoop:hadoop-common:2.7.2" in the Dependencies section of interpreter setting on GUI. But jdbc interpreter supposed to work without asking user hadoop-common dependency.
What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
On running this (JDBC) interpreter, the above stack trace should not come.
Screenshots (if appropriate)
Questions: